From patchwork Mon Jan 20 14:17:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 1225970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-517783-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=V7zI+/wv; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UNaUPj9U; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 481Yfx0ZYRz9sR4 for ; Tue, 21 Jan 2020 01:18:15 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:cc:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=I/tz6RMlMUQgY4Ee oA91lCmIcaZk6l9osuX1xMeJSOdZN5/QSkiGi/D8RY6THfOPQO7BEuiCqBs8tFsp XDQxYW44wAhagzMqRs9YkR6ubAzi9uendBXRJFLBdnoI3aLTRALdNUU0w+M0hCpD Su+lpuWph3HRZpWB8hjKF9u8IgU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:cc:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=w1PI+ZYa5RHsIis3a+4o4Q 5JCWQ=; b=V7zI+/wv60ZWlo+evv/D8J4YjN1YM4dBdHFUqMgVHz747LHuUSYhKM 7pf9fATPvsjDEycTLuNGZS4oqR2mTxTiNk1CJVUwA5+EqWJ7XwNOG/UoI21PhmWW goH+GBFHL9URaYpVDC5wyg8p9MTqB+OO0MGeP5PxaMUg/j07mMv1w= Received: (qmail 547 invoked by alias); 20 Jan 2020 14:18:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 538 invoked by uid 89); 20 Jan 2020 14:18:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=demangling, ian, Ian X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2020 14:17:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579529876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kXmXFMwfDDcgqEnehS/7BJoUe9dY10rVAqdWrKetxao=; b=UNaUPj9UFgzfrOCjuhKU4BDh0WQNuf1IS6qJsq2uxZ1l0njsissuFIEzTZFHVDfdpIsAKQ RnoSz0zUPZ54IPsqv4UO959RmhCzWtRJLDx2YA2yu9vH7B8fuHTBibMGIIbe4MKngI44gy cG3PwUceT3O4A1gyQYcZEFT46Y8US44= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-ymvoVL3zNtWCR01zBydvFA-1; Mon, 20 Jan 2020 09:17:53 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9D5E800A02; Mon, 20 Jan 2020 14:17:49 +0000 (UTC) Received: from comet.redhat.com (ovpn-117-87.ams2.redhat.com [10.36.117.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28F7D5C1BB; Mon, 20 Jan 2020 14:17:49 +0000 (UTC) From: Nick Clifton To: ian@airs.com Subject: RFA: Fix libiberty testsuite failure CC: gcc-patches@gcc.gnu.org Date: Mon, 20 Jan 2020 14:17:47 +0000 Message-ID: <87y2u28b5g.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-IsSubscribed: yes Hi Ian, The libiberty testsuite in the gcc mainline is currently failing on the last test: FAIL at line 1452, options : in: _Z3fooILPv0EEvPN9enable_ifIXeqT_LDnEEvE4typeE out: void foo<(void*)0>(enable_if<((void*)0)==(decltype(nullptr)), void>::type*) exp: void foo<(void*)0>(enable_if<((void*)0)==((decltype(nullptr))), void>::type*) To me it looks like the expected demangling is incorrect - it wants a double set of parentheses around decltype(nullptr) when I think that only one is needed. So I would like to apply the patch below to fix this. Is this OK ? Cheers Nick libiberty/ChangeLog 2020-01-20 Nick Clifton * testsuite/demangle-expected: Fix expected demangling. Index: libiberty/testsuite/demangle-expected =================================================================== --- libiberty/testsuite/demangle-expected (revision 280157) +++ libiberty/testsuite/demangle-expected (working copy) @@ -1449,4 +1449,4 @@ #PR91979 demangling nullptr expression _Z3fooILPv0EEvPN9enable_ifIXeqT_LDnEEvE4typeE -void foo<(void*)0>(enable_if<((void*)0)==((decltype(nullptr))), void>::type*) +void foo<(void*)0>(enable_if<((void*)0)==(decltype(nullptr)), void>::type*)