| Message ID | 20200120134820.24316-1-festevam@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | mx6sxsabresd: Keep only one target | expand |
> Subject: [PATCH] mx6sxsabresd: Keep only one target > > Currently there are two targets for the i.MX6SX SabreSD board: > mx6sxsabresd_defconfig and mx6sxsabresd_spl_defconfig. > > This brings additional maintainance effort without a clear advantage. > > Keep only the mx6sxsabresd_defconfig one and remove > mx6sxsabresd_spl_defconfig to keep it simpler. Should the board related spl code also be removed? Thanks, Peng. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > board/freescale/mx6sxsabresd/MAINTAINERS | 1 - > configs/mx6sxsabresd_spl_defconfig | 69 ------------------------ > 2 files changed, 70 deletions(-) > delete mode 100644 configs/mx6sxsabresd_spl_defconfig > > diff --git a/board/freescale/mx6sxsabresd/MAINTAINERS > b/board/freescale/mx6sxsabresd/MAINTAINERS > index 1dcec67545..a56d252edb 100644 > --- a/board/freescale/mx6sxsabresd/MAINTAINERS > +++ b/board/freescale/mx6sxsabresd/MAINTAINERS > @@ -4,4 +4,3 @@ S: Maintained > F: board/freescale/mx6sxsabresd/ > F: include/configs/mx6sxsabresd.h > F: configs/mx6sxsabresd_defconfig > -F: configs/mx6sxsabresd_spl_defconfig > diff --git a/configs/mx6sxsabresd_spl_defconfig > b/configs/mx6sxsabresd_spl_defconfig > deleted file mode 100644 > index 01ce26fbeb..0000000000 > -- > 2.17.1
Hi Peng,
On Mon, Jan 27, 2020 at 10:07 AM Peng Fan <peng.fan@nxp.com> wrote:
> Should the board related spl code also be removed?
Yes, I will send v2 with the SPL code removal.
Thanks
diff --git a/board/freescale/mx6sxsabresd/MAINTAINERS b/board/freescale/mx6sxsabresd/MAINTAINERS index 1dcec67545..a56d252edb 100644 --- a/board/freescale/mx6sxsabresd/MAINTAINERS +++ b/board/freescale/mx6sxsabresd/MAINTAINERS @@ -4,4 +4,3 @@ S: Maintained F: board/freescale/mx6sxsabresd/ F: include/configs/mx6sxsabresd.h F: configs/mx6sxsabresd_defconfig -F: configs/mx6sxsabresd_spl_defconfig
Currently there are two targets for the i.MX6SX SabreSD board: mx6sxsabresd_defconfig and mx6sxsabresd_spl_defconfig. This brings additional maintainance effort without a clear advantage. Keep only the mx6sxsabresd_defconfig one and remove mx6sxsabresd_spl_defconfig to keep it simpler. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- board/freescale/mx6sxsabresd/MAINTAINERS | 1 - configs/mx6sxsabresd_spl_defconfig | 69 ------------------------ 2 files changed, 70 deletions(-) delete mode 100644 configs/mx6sxsabresd_spl_defconfig diff --git a/configs/mx6sxsabresd_spl_defconfig b/configs/mx6sxsabresd_spl_defconfig deleted file mode 100644 index 01ce26fbeb..0000000000