| Message ID | 20200120104626.30518-1-warthog618@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpiolib: remove unnecessary argument from set_config call | expand |
pon., 20 sty 2020 o 11:46 Kent Gibson <warthog618@gmail.com> napisał(a): > > Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE. > > Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias") > Signed-off-by: Kent Gibson <warthog618@gmail.com> > --- > > No argument is expected by pinctrl, so removing it should be harmless. > This doesn't really fix any bug, does it? If not, then I'll just take it for v5.7 after the merge window. Bart
On Wed, Jan 29, 2020 at 11:55:49AM +0100, Bartosz Golaszewski wrote: > pon., 20 sty 2020 o 11:46 Kent Gibson <warthog618@gmail.com> napisał(a): > > > > Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE. > > > > Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias") > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > > --- > > > > No argument is expected by pinctrl, so removing it should be harmless. > > > > This doesn't really fix any bug, does it? If not, then I'll just take > it for v5.7 after the merge window. > This is just fixing what I suspect was a cut-and-paste error on my part that wasn't picked up during review - until I had a closer look following Geert and Andy's recent comments on some of your proposed changes. So it is just a tidy up. It could only a problem if a pinctrl is making use of the unnecessary argument, and there are no such pinctrls that I am aware of. Merge it in whenever it is convenient. Cheers, Kent.
śr., 29 sty 2020 o 13:33 Kent Gibson <warthog618@gmail.com> napisał(a): > > On Wed, Jan 29, 2020 at 11:55:49AM +0100, Bartosz Golaszewski wrote: > > pon., 20 sty 2020 o 11:46 Kent Gibson <warthog618@gmail.com> napisał(a): > > > > > > Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE. > > > > > > Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias") > > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > > > --- > > > > > > No argument is expected by pinctrl, so removing it should be harmless. > > > > > > > This doesn't really fix any bug, does it? If not, then I'll just take > > it for v5.7 after the merge window. > > > > This is just fixing what I suspect was a cut-and-paste error on my part > that wasn't picked up during review - until I had a closer look > following Geert and Andy's recent comments on some of your proposed > changes. So it is just a tidy up. > > It could only a problem if a pinctrl is making use of the unnecessary > argument, and there are no such pinctrls that I am aware of. > > Merge it in whenever it is convenient. > > Cheers, > Kent. I'm picking up various early fixes for v5.6 so I'll go ahead and apply it while at it. Bart
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 78a16e42f222..93d12fc9f82d 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3057,7 +3057,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned offset, unsigned arg; switch (mode) { - case PIN_CONFIG_BIAS_DISABLE: case PIN_CONFIG_BIAS_PULL_DOWN: case PIN_CONFIG_BIAS_PULL_UP: arg = 1;
Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE. Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias") Signed-off-by: Kent Gibson <warthog618@gmail.com> --- No argument is expected by pinctrl, so removing it should be harmless. drivers/gpio/gpiolib.c | 1 - 1 file changed, 1 deletion(-)