Patchwork [U-Boot] ARM: netspace_v2: fix warnings

login
register
mail settings
Submitter Anatolij Gustschin
Date Oct. 29, 2011, 9:31 p.m.
Message ID <1319923879-8783-1-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/122580/
State Accepted
Commit fc168cc56c88657eb51908890395ad7d9b366793
Delegated to: Albert ARIBAUD
Headers show

Comments

Anatolij Gustschin - Oct. 29, 2011, 9:31 p.m.
Fix compiler warnings when compiling for netspace_v2, netspace_max_v2
and inetspace_v2:

netspace_v2.c: In function 'board_early_init_f':
netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio'
netspace_v2.c: In function 'board_init':
netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Simon Guinot <simon.guinot@sequanux.org>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
 board/LaCie/netspace_v2/netspace_v2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Marek Vasut - Oct. 29, 2011, 10:36 p.m.
> Fix compiler warnings when compiling for netspace_v2, netspace_max_v2
> and inetspace_v2:
> 
> netspace_v2.c: In function 'board_early_init_f':
> netspace_v2.c:37: warning: implicit declaration of function
> 'kw_config_gpio' netspace_v2.c: In function 'board_init':
> netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Simon Guinot <simon.guinot@sequanux.org>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  board/LaCie/netspace_v2/netspace_v2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/board/LaCie/netspace_v2/netspace_v2.c
> b/board/LaCie/netspace_v2/netspace_v2.c index 3bb83f3..7c4b15e 100644
> --- a/board/LaCie/netspace_v2/netspace_v2.c
> +++ b/board/LaCie/netspace_v2/netspace_v2.c
> @@ -24,6 +24,7 @@
>  #include <miiphy.h>
>  #include <netdev.h>
>  #include <command.h>
> +#include <asm/arch/cpu.h>
>  #include <asm/arch/kirkwood.h>
>  #include <asm/arch/mpp.h>
>  #include <asm/arch/gpio.h>

Acked-by: Marek Vasut <marek.vasut@gmail.com>
Albert ARIBAUD - Oct. 30, 2011, 10:45 a.m.
Hi Anatolij,

Le 29/10/2011 23:31, Anatolij Gustschin a écrit :
> Fix compiler warnings when compiling for netspace_v2, netspace_max_v2
> and inetspace_v2:
>
> netspace_v2.c: In function 'board_early_init_f':
> netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio'
> netspace_v2.c: In function 'board_init':
> netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'
>
> Signed-off-by: Anatolij Gustschin<agust@denx.de>
> Cc: Simon Guinot<simon.guinot@sequanux.org>
> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
> ---
>   board/LaCie/netspace_v2/netspace_v2.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/board/LaCie/netspace_v2/netspace_v2.c b/board/LaCie/netspace_v2/netspace_v2.c
> index 3bb83f3..7c4b15e 100644
> --- a/board/LaCie/netspace_v2/netspace_v2.c
> +++ b/board/LaCie/netspace_v2/netspace_v2.c
> @@ -24,6 +24,7 @@
>   #include<miiphy.h>
>   #include<netdev.h>
>   #include<command.h>
> +#include<asm/arch/cpu.h>
>   #include<asm/arch/kirkwood.h>
>   #include<asm/arch/mpp.h>
>   #include<asm/arch/gpio.h>

Applied to u-boot-arm/master, as a bugfix to help netspace_v2 compile clean.

Note however that I also see the following warning for netspace_v2:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'

Amicalement,
Anatolij Gustschin - Oct. 30, 2011, 11:34 a.m.
Hi Albert,

On Sun, 30 Oct 2011 11:45:37 +0100
Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
...
> Applied to u-boot-arm/master, as a bugfix to help netspace_v2 compile clean.
> 
> Note however that I also see the following warning for netspace_v2:
> 
> mvgbe.c: In function 'mvgbe_initialize':
> mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'

This one is fixed by another patch for fixing dockstar compile breakage
I've applied before [1]. There is also another patch for fixing dreamplug
breakage [2]. Can you apply them too? I've resend the dockstar patch, but
forgot to tag it as v2, sorry.
 
Thanks,
Anatolij

[1] http://patchwork.ozlabs.org/patch/122575/
[2] http://patchwork.ozlabs.org/patch/122579/
Simon Guinot - Oct. 30, 2011, 12:40 p.m.
On Sat, Oct 29, 2011 at 11:31:19PM +0200, Anatolij Gustschin wrote:
> Fix compiler warnings when compiling for netspace_v2, netspace_max_v2
> and inetspace_v2:
> 
> netspace_v2.c: In function 'board_early_init_f':
> netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio'
> netspace_v2.c: In function 'board_init':
> netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'

It seems to me this regression has been introduced by:

commit a7efd719f415833a833d6a8e46bcd470a0847ecc
Author: Lei Wen <[leiwen@marvell.com]>
Date:   Tue Oct 18 20:11:42 2011 +0530

    ARM: kirkwood: reduce dependence of including platform file
    
    For files like the drivers/serial/serial.c, it must include the
    platform file, as the CONFIG_SYS_NS16550_COM1 must reference to the
    definition in the platform definition files.
    
    Include the platform definition file in the config file, so that it
    would decouple the dependence for the driver files.
    
    Signed-off-by: Lei Wen <leiwen@marvell.com>

Maybe that more boards are affected.

> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Simon Guinot <simon.guinot@sequanux.org>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  board/LaCie/netspace_v2/netspace_v2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/board/LaCie/netspace_v2/netspace_v2.c b/board/LaCie/netspace_v2/netspace_v2.c
> index 3bb83f3..7c4b15e 100644
> --- a/board/LaCie/netspace_v2/netspace_v2.c
> +++ b/board/LaCie/netspace_v2/netspace_v2.c
> @@ -24,6 +24,7 @@
>  #include <miiphy.h>
>  #include <netdev.h>
>  #include <command.h>
> +#include <asm/arch/cpu.h>
>  #include <asm/arch/kirkwood.h>
>  #include <asm/arch/mpp.h>
>  #include <asm/arch/gpio.h>

Acked-by: Simon Guinot <simon.guinot@sequanux.org>

Thanks for the compilation clean-up.

Simon
Albert ARIBAUD - Oct. 30, 2011, 4:19 p.m.
Hi Anatolij,

Le 30/10/2011 12:34, Anatolij Gustschin a écrit :
> Hi Albert,
>
> On Sun, 30 Oct 2011 11:45:37 +0100
> Albert ARIBAUD<albert.u.boot@aribaud.net>  wrote:
> ...
>> Applied to u-boot-arm/master, as a bugfix to help netspace_v2 compile clean.
>>
>> Note however that I also see the following warning for netspace_v2:
>>
>> mvgbe.c: In function 'mvgbe_initialize':
>> mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'
>
> This one is fixed by another patch for fixing dockstar compile breakage
> I've applied before [1]. There is also another patch for fixing dreamplug
> breakage [2]. Can you apply them too? I've resend the dockstar patch, but
> forgot to tag it as v2, sorry.
>
> Thanks,
> Anatolij
>
> [1] http://patchwork.ozlabs.org/patch/122575/
> [2] http://patchwork.ozlabs.org/patch/122579/

I take both in u-boot-arm/master as bug fixes.

Amicalement,
Anatolij Gustschin - Oct. 30, 2011, 4:21 p.m.
Hi Albert,

On Sun, 30 Oct 2011 17:19:58 +0100
Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
...
> > [1] http://patchwork.ozlabs.org/patch/122575/
> > [2] http://patchwork.ozlabs.org/patch/122579/
> 
> I take both in u-boot-arm/master as bug fixes.

Thanks!

Anatolij

Patch

diff --git a/board/LaCie/netspace_v2/netspace_v2.c b/board/LaCie/netspace_v2/netspace_v2.c
index 3bb83f3..7c4b15e 100644
--- a/board/LaCie/netspace_v2/netspace_v2.c
+++ b/board/LaCie/netspace_v2/netspace_v2.c
@@ -24,6 +24,7 @@ 
 #include <miiphy.h>
 #include <netdev.h>
 #include <command.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include <asm/arch/gpio.h>