Patchwork [U-Boot] ARM: dreamplug: fix compilation

login
register
mail settings
Submitter Anatolij Gustschin
Date Oct. 29, 2011, 9:19 p.m.
Message ID <1319923187-19917-1-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/122579/
State Accepted
Commit 0ac16bf32d3c3c9c76ede002a49ab4e864a57e57
Delegated to: Albert ARIBAUD
Headers show

Comments

Anatolij Gustschin - Oct. 29, 2011, 9:19 p.m.
Fix build issues:

mvrtc.c: In function 'rtc_get':
mvrtc.c:45: warning: implicit declaration of function 'readl'
mvrtc.c: In function 'rtc_set':
mvrtc.c:100: warning: implicit declaration of function 'writel'
dreamplug.c: In function 'board_early_init_f':
dreamplug.c:43: warning: implicit declaration of function 'kw_config_gpio'
dreamplug.c: In function 'board_init':
dreamplug.c:108: warning: implicit declaration of function 'kw_sdram_bar'
drivers/rtc/librtc.o: In function `rtc_set':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:92: undefined reference to `writel'
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:103: undefined reference to `writel'
drivers/rtc/librtc.o: In function `rtc_reset':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:117: undefined reference to `readl'
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:120: undefined reference to `readl'
drivers/rtc/librtc.o: In function `rtc_get':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:45: undefined reference to `readl'
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:48: undefined reference to `readl'
...

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Jason Cooper <u-boot@lakedaemon.net>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
 board/Marvell/dreamplug/dreamplug.c |    1 +
 drivers/rtc/mvrtc.c                 |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Marek Vasut - Oct. 29, 2011, 10:36 p.m.
> Fix build issues:
> 
> mvrtc.c: In function 'rtc_get':
> mvrtc.c:45: warning: implicit declaration of function 'readl'
> mvrtc.c: In function 'rtc_set':
> mvrtc.c:100: warning: implicit declaration of function 'writel'
> dreamplug.c: In function 'board_early_init_f':
> dreamplug.c:43: warning: implicit declaration of function 'kw_config_gpio'
> dreamplug.c: In function 'board_init':
> dreamplug.c:108: warning: implicit declaration of function 'kw_sdram_bar'
> drivers/rtc/librtc.o: In function `rtc_set':
> /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:92:
> undefined reference to `writel'
> /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:103:
> undefined reference to `writel' drivers/rtc/librtc.o: In function
> `rtc_reset':
> /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:117:
> undefined reference to `readl'
> /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:120:
> undefined reference to `readl' drivers/rtc/librtc.o: In function
> `rtc_get':
> /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:45:
> undefined reference to `readl'
> /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:48:
> undefined reference to `readl' ...
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Jason Cooper <u-boot@lakedaemon.net>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  board/Marvell/dreamplug/dreamplug.c |    1 +
>  drivers/rtc/mvrtc.c                 |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/board/Marvell/dreamplug/dreamplug.c
> b/board/Marvell/dreamplug/dreamplug.c index 13b4013..31b73c9 100644
> --- a/board/Marvell/dreamplug/dreamplug.c
> +++ b/board/Marvell/dreamplug/dreamplug.c
> @@ -27,6 +27,7 @@
> 
>  #include <common.h>
>  #include <miiphy.h>
> +#include <asm/arch/cpu.h>
>  #include <asm/arch/kirkwood.h>
>  #include <asm/arch/mpp.h>
>  #include "dreamplug.h"
> diff --git a/drivers/rtc/mvrtc.c b/drivers/rtc/mvrtc.c
> index ccc573a..edc1f4f 100644
> --- a/drivers/rtc/mvrtc.c
> +++ b/drivers/rtc/mvrtc.c
> @@ -28,6 +28,7 @@
>  #include <common.h>
>  #include <command.h>
>  #include <rtc.h>
> +#include <asm/io.h>
>  #include "mvrtc.h"
> 
>  /* This RTC does not support century, so we assume 20 */

How the heck did you get this? I MAKEALL-ed all ARM boards and didn't get this 
crap.

Either way:

Acked-by: Marek Vasut <marek.vasut@gmail.com>
Anatolij Gustschin - Oct. 29, 2011, 11:12 p.m.
Hi,

On Sun, 30 Oct 2011 00:36:51 +0200
Marek Vasut <marek.vasut@gmail.com> wrote:
...
> How the heck did you get this? I MAKEALL-ed all ARM boards and didn't get this 
> crap.

It showed up when running 'MAKEALL arm' in my u-boot-video repo.
It also shows up on current u-boot master when running './MAKEALL dreamplug'.
In both tests I used ELDK-4.2 ARM toolchain. The issue also show up when
running './MAKEALL dreamplug' using current u-boot-arm/master.

Anatolij
Marek Vasut - Oct. 29, 2011, 11:19 p.m.
> Hi,
> 
> On Sun, 30 Oct 2011 00:36:51 +0200
> Marek Vasut <marek.vasut@gmail.com> wrote:
> ...
> 
> > How the heck did you get this? I MAKEALL-ed all ARM boards and didn't get
> > this crap.
> 
> It showed up when running 'MAKEALL arm' in my u-boot-video repo.
> It also shows up on current u-boot master when running './MAKEALL
> dreamplug'. In both tests I used ELDK-4.2 ARM toolchain. The issue also
> show up when running './MAKEALL dreamplug' using current
> u-boot-arm/master.
> 
> Anatolij

I'll re-run my tests, thanks !!!

Patch

diff --git a/board/Marvell/dreamplug/dreamplug.c b/board/Marvell/dreamplug/dreamplug.c
index 13b4013..31b73c9 100644
--- a/board/Marvell/dreamplug/dreamplug.c
+++ b/board/Marvell/dreamplug/dreamplug.c
@@ -27,6 +27,7 @@ 
 
 #include <common.h>
 #include <miiphy.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include "dreamplug.h"
diff --git a/drivers/rtc/mvrtc.c b/drivers/rtc/mvrtc.c
index ccc573a..edc1f4f 100644
--- a/drivers/rtc/mvrtc.c
+++ b/drivers/rtc/mvrtc.c
@@ -28,6 +28,7 @@ 
 #include <common.h>
 #include <command.h>
 #include <rtc.h>
+#include <asm/io.h>
 #include "mvrtc.h"
 
 /* This RTC does not support century, so we assume 20 */