[v2] igc: Fix the typo in comment
diff mbox series

Message ID 20200120061758.25650-1-sasha.neftin@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show
Series
  • [v2] igc: Fix the typo in comment
Related show

Commit Message

Sasha Neftin Jan. 20, 2020, 6:17 a.m. UTC
Fix the typo and comment to correspond to the i225 device
v1->v2:
Address community comment

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
 drivers/net/ethernet/intel/igc/igc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinicius Costa Gomes Jan. 21, 2020, 10:26 p.m. UTC | #1
Hi Sasha,

Sasha Neftin <sasha.neftin@intel.com> writes:

> Fix the typo and comment to correspond to the i225 device
> v1->v2:
> Address community comment
>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>  drivers/net/ethernet/intel/igc/igc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
> index 5d38d0faeced..cb1362188c2a 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -112,7 +112,7 @@ extern char igc_driver_version[];
>  #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
>  
>  /* Transmit and receive latency (for PTP timestamps) */
> -/* FIXME: These values were estimated using the ones that i210 has as
> +/* FIXME: These values were estimated using the ones that i225 has as
>   * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
>   * need to confirm them.
>   */

If you are sending this patch, it means that I couldn't explain myself
well enough. The idea of that comment was to point out that the
documentation doesn't provide an estimate of those values, so I used the
ones from the i210 datasheet.


Cheers,
--
Vinicius

Patch
diff mbox series

diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index 5d38d0faeced..cb1362188c2a 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -112,7 +112,7 @@  extern char igc_driver_version[];
 #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
 
 /* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* FIXME: These values were estimated using the ones that i225 has as
  * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
  * need to confirm them.
  */