[2/2] syscalls/add_key01: remove duplicated case
diff mbox series

Message ID 1579420198-29651-2-git-send-email-xuyang2018.jy@cn.fujitsu.com
State Changes Requested
Headers show
Series
  • Untitled series #154042
Related show

Commit Message

Yang Xu Jan. 19, 2020, 7:49 a.m. UTC
Since add_key05.c has covered this test point, remove it.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 runtest/syscalls                              |  1 -
 testcases/kernel/syscalls/add_key/.gitignore  |  1 -
 testcases/kernel/syscalls/add_key/add_key01.c | 26 -------------------
 3 files changed, 28 deletions(-)
 delete mode 100644 testcases/kernel/syscalls/add_key/add_key01.c

Comments

Cyril Hrubis Jan. 21, 2020, 2:50 p.m. UTC | #1
Hi!
Can't we just change the test instead of creating add_key05 then
removing add_key01?

Patch
diff mbox series

diff --git a/runtest/syscalls b/runtest/syscalls
index 830dfc8b7..04db95cf5 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -14,7 +14,6 @@  access04 access04
 acct01 acct01
 acct02 acct02
 
-add_key01 add_key01
 add_key02 add_key02
 add_key03 add_key03
 add_key04 add_key04
diff --git a/testcases/kernel/syscalls/add_key/.gitignore b/testcases/kernel/syscalls/add_key/.gitignore
index f57dc2228..49acda06b 100644
--- a/testcases/kernel/syscalls/add_key/.gitignore
+++ b/testcases/kernel/syscalls/add_key/.gitignore
@@ -1,4 +1,3 @@ 
-/add_key01
 /add_key02
 /add_key03
 /add_key04
diff --git a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c
deleted file mode 100644
index 4fe97dac6..000000000
--- a/testcases/kernel/syscalls/add_key/add_key01.c
+++ /dev/null
@@ -1,26 +0,0 @@ 
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * Copyright (c) Crackerjack Project., 2007
- * Porting from Crackerjack to LTP is done by
- * Manas Kumar Nayak maknayak@in.ibm.com>
- *
- * Basic test for the add_key() syscall.
- */
-
-#include <errno.h>
-
-#include "tst_test.h"
-#include "lapi/keyctl.h"
-
-static void verify_add_key(void)
-{
-	TEST(add_key("keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING));
-	if (TST_RET == -1)
-		tst_res(TFAIL | TTERRNO, "add_key call failed");
-	else
-		tst_res(TPASS, "add_key call succeeded");
-}
-
-static struct tst_test test = {
-	.test_all = verify_add_key,
-};