From patchwork Sat Jan 18 01:20:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Nisbet, Chris" X-Patchwork-Id: 1225100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nisbet.kiwi.nz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4800k53lw1z9sR0 for ; Sat, 18 Jan 2020 12:30:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729797AbgARBaf (ORCPT ); Fri, 17 Jan 2020 20:30:35 -0500 Received: from omr2.mail.isx.net.nz ([111.65.230.131]:55792 "EHLO omr2.mail.isx.net.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbgARBaf (ORCPT ); Fri, 17 Jan 2020 20:30:35 -0500 X-Greylist: delayed 594 seconds by postgrey-1.27 at vger.kernel.org; Fri, 17 Jan 2020 20:30:34 EST Received: from [10.55.1.24] (unknown [203.109.234.80]) (Authenticated sender: chris@nisbet.kiwi.nz) by omr2.mail.isx.net.nz (Postfix) with ESMTPA id 56F4C9372C1 for ; Sat, 18 Jan 2020 14:20:39 +1300 (NZDT) To: linux-gpio@vger.kernel.org From: "Nisbet, Chris" Subject: [libgpiod] [PATCH] iter: remove unnecessary indirection in free_dirs Message-ID: <92120a07-6945-1be9-15de-9e9a461c45bc@nisbet.kiwi.nz> Date: Sat, 18 Jan 2020 14:20:38 +1300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It is not necessary to pass the address of the 'dirs' variable to dirs_free(), so this commit removes the unnecessary indirection. Signed-off-by: Chris Nisbet ---  lib/iter.c | 10 +++++-----  1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/iter.c b/lib/iter.c index a4d883a..bfd2852 100644 --- a/lib/iter.c +++ b/lib/iter.c @@ -28,13 +28,13 @@ static int dir_filter(const struct dirent *dir)      return !strncmp(dir->d_name, "gpiochip", 8);  } -static void free_dirs(struct dirent ***dirs, unsigned int num_dirs) +static void free_dirs(struct dirent **dirs, unsigned int num_dirs)  {      unsigned int i;      for (i = 0; i < num_dirs; i++) -        free((*dirs)[i]); -    free(*dirs); +        free(dirs[i]); +    free(dirs);  }  struct gpiod_chip_iter *gpiod_chip_iter_new(void) @@ -69,7 +69,7 @@ struct gpiod_chip_iter *gpiod_chip_iter_new(void)              goto err_close_chips;      } -    free_dirs(&dirs, num_chips); +    free_dirs(dirs, num_chips);      return iter; @@ -85,7 +85,7 @@ err_free_iter:      free(iter);  err_free_dirs: -    free_dirs(&dirs, num_chips); +    free_dirs(dirs, num_chips);      return NULL;  }