[v2,3/4] linux-user: remove gemu_log from the linux-user tree
diff mbox series

Message ID 20200117192808.129398-4-jkz@google.com
State New
Headers show
Series
  • migration: Replace gemu_log with qemu_log
Related show

Commit Message

Josh Kunz Jan. 17, 2020, 7:28 p.m. UTC
Now that all uses have been migrated to `qemu_log' it is no longer
needed.

Signed-off-by: Josh Kunz <jkz@google.com>
---
 linux-user/main.c | 9 ---------
 linux-user/qemu.h | 1 -
 2 files changed, 10 deletions(-)

Comments

Laurent Vivier Jan. 28, 2020, 3:07 p.m. UTC | #1
Le 17/01/2020 à 20:28, Josh Kunz a écrit :
> Now that all uses have been migrated to `qemu_log' it is no longer
> needed.
> 
> Signed-off-by: Josh Kunz <jkz@google.com>
> ---
>  linux-user/main.c | 9 ---------
>  linux-user/qemu.h | 1 -
>  2 files changed, 10 deletions(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 8f1d07cdd6..22578b1633 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -112,15 +112,6 @@ const char *qemu_uname_release;
>     by remapping the process stack directly at the right place */
>  unsigned long guest_stack_size = 8 * 1024 * 1024UL;
>  
> -void gemu_log(const char *fmt, ...)
> -{
> -    va_list ap;
> -
> -    va_start(ap, fmt);
> -    vfprintf(stderr, fmt, ap);
> -    va_end(ap);
> -}
> -
>  #if defined(TARGET_I386)
>  int cpu_get_pic_interrupt(CPUX86State *env)
>  {
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 02c6890c8a..329b409e65 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -210,7 +210,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>                      abi_long arg2, abi_long arg3, abi_long arg4,
>                      abi_long arg5, abi_long arg6, abi_long arg7,
>                      abi_long arg8);
> -void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
>  extern __thread CPUState *thread_cpu;
>  void cpu_loop(CPUArchState *env);
>  const char *target_strerror(int err);
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Patch
diff mbox series

diff --git a/linux-user/main.c b/linux-user/main.c
index 8f1d07cdd6..22578b1633 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -112,15 +112,6 @@  const char *qemu_uname_release;
    by remapping the process stack directly at the right place */
 unsigned long guest_stack_size = 8 * 1024 * 1024UL;
 
-void gemu_log(const char *fmt, ...)
-{
-    va_list ap;
-
-    va_start(ap, fmt);
-    vfprintf(stderr, fmt, ap);
-    va_end(ap);
-}
-
 #if defined(TARGET_I386)
 int cpu_get_pic_interrupt(CPUX86State *env)
 {
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 02c6890c8a..329b409e65 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -210,7 +210,6 @@  abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                     abi_long arg2, abi_long arg3, abi_long arg4,
                     abi_long arg5, abi_long arg6, abi_long arg7,
                     abi_long arg8);
-void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
 extern __thread CPUState *thread_cpu;
 void cpu_loop(CPUArchState *env);
 const char *target_strerror(int err);