diff mbox series

[1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()

Message ID 20200116154533.10743-1-alifer.wsdm@gmail.com
State Accepted
Commit f04887f73b0dc711d8c01efdf6c6bb53e597cde6
Delegated to: Stefano Babic
Headers show
Series [1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info() | expand

Commit Message

Alifer Moraes Jan. 16, 2020, 3:45 p.m. UTC
detail_board_ddr_info() is not used anywhere, so simply remove it.

This function is only used by Layerscape, not by i.MX.

This was detected by the following sparse warning:

board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous
prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]

Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
---
 board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Oliver Graute Jan. 17, 2020, 7:47 a.m. UTC | #1
On 16/01/20, Alifer Moraes wrote:
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> 
> This function is only used by Layerscape, not by i.MX.
> 
> This was detected by the following sparse warning:
> 
> board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous
> prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]
> 
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>

Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>
Stefano Babic Jan. 20, 2020, 8:17 p.m. UTC | #2
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous
> prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
> Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c b/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
index 2f97d5ce96..8bcbcc0e3f 100644
--- a/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
+++ b/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
@@ -107,11 +107,6 @@  int board_init(void)
 	return 0;
 }
 
-void detail_board_ddr_info(void)
-{
-	puts("\nDDR    ");
-}
-
 /*
  * Board specific reset that is system reset.
  */