[2/3] arm: dts: exynos: Fix card-detect polarity for SD card on Odroid U3/X2
diff mbox series

Message ID 20200116152535.2170-3-m.szyprowski@samsung.com
State Accepted
Commit 1bca28a5d98a81a9d189a46347f8a92619624f94
Delegated to: Minkyu Kang
Headers show
Series
  • Fix Odroid U3/X2 SD-card boot
Related show

Commit Message

Marek Szyprowski Jan. 16, 2020, 3:25 p.m. UTC
Card detect line for SD-card on Odroid U3/X2 boards are active low, so
add cd-inverted property to indicate this, as u-boot's GPIO driver doesn't
support specifying line polarity. This restores S5P_SDHCI driver operation
on Odroid U3/X2 boards.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/dts/exynos4412-odroid.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Anand Moon Jan. 17, 2020, 4:56 a.m. UTC | #1
Hi Marek,

On Thu, 16 Jan 2020 at 20:56, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Card detect line for SD-card on Odroid U3/X2 boards are active low, so
> add cd-inverted property to indicate this, as u-boot's GPIO driver doesn't
> support specifying line polarity. This restores S5P_SDHCI driver operation
> on Odroid U3/X2 boards.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---

Please add my
Reviewed-by: Anand Moon <linux.amoon@gmail.com>

-Anand

Patch
diff mbox series

diff --git a/arch/arm/dts/exynos4412-odroid.dts b/arch/arm/dts/exynos4412-odroid.dts
index cc8e0dd041..e6c7222755 100644
--- a/arch/arm/dts/exynos4412-odroid.dts
+++ b/arch/arm/dts/exynos4412-odroid.dts
@@ -236,6 +236,7 @@ 
 &sdhci2 {
 	samsung,bus-width = <4>;
 	samsung,timing = <1 2 3>;
+	cd-inverted;
 	cd-gpios = <&gpk2 2 0>;
 	status = "okay";
 };