[v3] arm: exynos: Use proper PMIC device names
diff mbox series

Message ID 20200116134604.12217-1-m.szyprowski@samsung.com
State Accepted
Commit 4b8984e969fa8e68f2fdd79c70cd4be8f1f1378c
Delegated to: Minkyu Kang
Headers show
Series
  • [v3] arm: exynos: Use proper PMIC device names
Related show

Commit Message

Marek Szyprowski Jan. 16, 2020, 1:46 p.m. UTC
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by
name") one has to provide full name to get requested object. Fix the code
used to detect enable power regulators on the supported Exynos boards to
use proper PMIC device device name then.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
---
v3:
- Fixed max77686 and s5m8767 PMIC too
---
 board/samsung/common/exynos5-dt-types.c | 2 +-
 board/samsung/common/exynos5-dt.c       | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Minkyu Kang Jan. 28, 2020, 9:14 a.m. UTC | #1
On 16/01/2020 22:46, Marek Szyprowski wrote:
> Since commit 4213609cc7 ("drivers: core: use strcmp when find device by
> name") one has to provide full name to get requested object. Fix the code
> used to detect enable power regulators on the supported Exynos boards to
> use proper PMIC device device name then.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Anand Moon <linux.amoon@gmail.com>
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
> ---
> v3:
> - Fixed max77686 and s5m8767 PMIC too
> ---
>  board/samsung/common/exynos5-dt-types.c | 2 +-
>  board/samsung/common/exynos5-dt.c       | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

Patch
diff mbox series

diff --git a/board/samsung/common/exynos5-dt-types.c b/board/samsung/common/exynos5-dt-types.c
index d51cc4eedc..1413dc8978 100644
--- a/board/samsung/common/exynos5-dt-types.c
+++ b/board/samsung/common/exynos5-dt-types.c
@@ -129,7 +129,7 @@  static const char *odroid_get_type_str(void)
 	if (gd->board_type != EXYNOS5_BOARD_ODROID_XU3_REV02)
 		goto exit;
 
-	ret = pmic_get("s2mps11", &dev);
+	ret = pmic_get("s2mps11_pmic@66", &dev);
 	if (ret)
 		goto exit;
 
diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c
index 387d1b9180..eef46b0dc4 100644
--- a/board/samsung/common/exynos5-dt.c
+++ b/board/samsung/common/exynos5-dt.c
@@ -65,9 +65,9 @@  int exynos_power_init(void)
 	int ret;
 
 #ifdef CONFIG_PMIC_S2MPS11
-	ret = pmic_get("s2mps11_pmic", &dev);
+	ret = pmic_get("s2mps11_pmic@66", &dev);
 #else
-	ret = pmic_get("max77686", &dev);
+	ret = pmic_get("max77686_pmic@09", &dev);
 	if (!ret) {
 		/* TODO(sjg@chromium.org): Move into the clock/pmic API */
 		ret = pmic_clrsetbits(dev, MAX77686_REG_PMIC_32KHZ, 0,
@@ -79,7 +79,7 @@  int exynos_power_init(void)
 		if (ret)
 			return ret;
 	} else {
-		ret = pmic_get("s5m8767-pmic", &dev);
+		ret = pmic_get("s5m8767_pmic@66", &dev);
 		/* TODO(sjg@chromium.org): Use driver model to access clock */
 #ifdef CONFIG_PMIC_S5M8767
 		if (!ret)