| Message ID | 20200116131631.31724-1-m.grzeschik@pengutronix.de |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v4] net: phy: dp83867: Set FORCE_LINK_GOOD to default after reset | expand |
On Thu, Jan 16, 2020 at 02:16:31PM +0100, Michael Grzeschik wrote: > According to the Datasheet this bit should be 0 (Normal operation) in > default. With the FORCE_LINK_GOOD bit set, it is not possible to get a > link. This patch sets FORCE_LINK_GOOD to the default value after > resetting the phy. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Michael Grzeschik <m.grzeschik@pengutronix.de> Date: Thu, 16 Jan 2020 14:16:31 +0100 > According to the Datasheet this bit should be 0 (Normal operation) in > default. With the FORCE_LINK_GOOD bit set, it is not possible to get a > link. This patch sets FORCE_LINK_GOOD to the default value after > resetting the phy. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Applied and queued up for -stable.
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 9cd9dcee4eb2e..01cf71358359a 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -97,6 +97,7 @@ #define DP83867_PHYCR_FIFO_DEPTH_MAX 0x03 #define DP83867_PHYCR_FIFO_DEPTH_MASK GENMASK(15, 14) #define DP83867_PHYCR_RESERVED_MASK BIT(11) +#define DP83867_PHYCR_FORCE_LINK_GOOD BIT(10) /* RGMIIDCTL bits */ #define DP83867_RGMII_TX_CLK_DELAY_MAX 0xf @@ -599,7 +600,12 @@ static int dp83867_phy_reset(struct phy_device *phydev) usleep_range(10, 20); - return 0; + /* After reset FORCE_LINK_GOOD bit is set. Although the + * default value should be unset. Disable FORCE_LINK_GOOD + * for the phy to work properly. + */ + return phy_modify(phydev, MII_DP83867_PHYCTRL, + DP83867_PHYCR_FORCE_LINK_GOOD, 0); } static struct phy_driver dp83867_driver[] = {
According to the Datasheet this bit should be 0 (Normal operation) in default. With the FORCE_LINK_GOOD bit set, it is not possible to get a link. This patch sets FORCE_LINK_GOOD to the default value after resetting the phy. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- v1 -> v2: - fixed typo in subject line - used phy_modify instead of read/write v2 -> v3: - returned dp83867_phy_reset with phy_modify call v3 -> v4: - rebased to net branch drivers/net/phy/dp83867.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)