gpio: Fix the no return statement warning for gpiochip_populate_parent_fwspec_twocell/fourcell()
diff mbox series

Message ID 20200116095003.30324-1-haokexin@gmail.com
State New
Headers show
Series
  • gpio: Fix the no return statement warning for gpiochip_populate_parent_fwspec_twocell/fourcell()
Related show

Commit Message

Kevin Hao Jan. 16, 2020, 9:50 a.m. UTC
In commit 242587616710 ("gpiolib: Add support for the irqdomain which
doesn't use irq_fwspec as arg") we have changed the return type of
gpiochip_populate_parent_fwspec_twocell/fourcell() from void to void *,
but forgot to add a return statement for these two dummy functions.
Add "return NULL" to fix the build warnings.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
 include/linux/gpio/driver.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Linus Walleij Jan. 16, 2020, 10:30 a.m. UTC | #1
On Thu, Jan 16, 2020 at 11:01 AM Kevin Hao <haokexin@gmail.com> wrote:

> In commit 242587616710 ("gpiolib: Add support for the irqdomain which
> doesn't use irq_fwspec as arg") we have changed the return type of
> gpiochip_populate_parent_fwspec_twocell/fourcell() from void to void *,
> but forgot to add a return statement for these two dummy functions.
> Add "return NULL" to fix the build warnings.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>

Patch applied on top of the other fixes and pushed for inclusion
in linux-next!

Thanks for your hard work on fixing this Kevin!

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index ea6e615ad7fc..18350f274905 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -549,12 +549,14 @@  static inline void *gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *ch
 						    unsigned int parent_hwirq,
 						    unsigned int parent_type)
 {
+	return NULL;
 }
 
 static inline void *gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 						     unsigned int parent_hwirq,
 						     unsigned int parent_type)
 {
+	return NULL;
 }
 
 #endif /* CONFIG_IRQ_DOMAIN_HIERARCHY */