| Message ID | 20200115200250.10849-1-krzk@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/3] i2c: pmcmsp: Use proper printk format for resource_size_t | expand |
On Wed, Jan 15, 2020 at 09:02:48PM +0100, Krzysztof Kozlowski wrote: > resource_size_t should be printed with its own size-independent format > to fix warnings when compiling on 64-bit platform (e.g. with > COMPILE_TEST): > > drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’: > drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning: > format ‘%x’ expects argument of type ‘unsigned int’, > but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=] > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 4fde74eb34a7..5d89c7c1b3a8 100644 --- a/drivers/i2c/busses/i2c-pmcmsp.c +++ b/drivers/i2c/busses/i2c-pmcmsp.c @@ -274,8 +274,8 @@ static int pmcmsptwi_probe(struct platform_device *pldev) if (!request_mem_region(res->start, resource_size(res), pldev->name)) { dev_err(&pldev->dev, - "Unable to get memory/io address region 0x%08x\n", - res->start); + "Unable to get memory/io address region %pap\n", + &res->start); rc = -EBUSY; goto ret_err; } @@ -285,7 +285,7 @@ static int pmcmsptwi_probe(struct platform_device *pldev) resource_size(res)); if (!pmcmsptwi_data.iobase) { dev_err(&pldev->dev, - "Unable to ioremap address 0x%08x\n", res->start); + "Unable to ioremap address %pap\n", &res->start); rc = -EIO; goto ret_unreserve; }
resource_size_t should be printed with its own size-independent format to fix warnings when compiling on 64-bit platform (e.g. with COMPILE_TEST): drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’: drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=] Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v2: 1. Remove parentheses around res->start. Changes since v1: 1. Use %pap, not %pa[p]. --- drivers/i2c/busses/i2c-pmcmsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)