diff mbox series

[OpenWrt-Devel] cryptodev-linux: remove DEFAULT redefinition

Message ID 20200115182805.14907-1-cotequeiroz@gmail.com
State Accepted
Headers show
Series [OpenWrt-Devel] cryptodev-linux: remove DEFAULT redefinition | expand

Commit Message

Eneas U de Queiroz Jan. 15, 2020, 6:28 p.m. UTC 
The 'DEFAULT:=m if ALL' line prevents the phase1 buildbots from building
the package, and users from downloading it, since they use 'ALL_KMODS=y'
but 'ALL' is not set.

Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
--
This was reported here: https://github.com/openwrt/packages/issues/10987

This should be cherry-picked to openwrt-19.07 as well. 

Note that in 18.06, to actually be able to use cryptodev, you'd have to
custom-build openssl (or gnutls), since the engine was always built into
the main library.  Therefore there's little benefit in applying this
patch.  From 19.07, the openssl devcrypto engine is built into a
separate package, which has kmod-cryptodev as a dependency.

It was compile/behavior-tested on mvebu and using the ramips-mt7620 SDK.

I decided not to bump PKG_RELEASE, since this does not change the
package, just whether it gets built or not.

Comments

Jo-Philipp Wich Jan. 15, 2020, 6:30 p.m. UTC | #1 
Merged into my staging tree at
http://git.openwrt.org/?p=openwrt/staging/jow.git.

Thank you!
diff mbox series

Patch

diff --git a/package/kernel/cryptodev-linux/Makefile b/package/kernel/cryptodev-linux/Makefile
index 2a8890286d..9bea63ebd1 100644
--- a/package/kernel/cryptodev-linux/Makefile
+++ b/package/kernel/cryptodev-linux/Makefile
@@ -27,7 +27,6 @@  include $(INCLUDE_DIR)/package.mk
 
 define KernelPackage/cryptodev
   SUBMENU:=Cryptographic API modules
-  DEFAULT:=m if ALL
   TITLE:=Driver for cryptographic acceleration
   URL:=http://cryptodev-linux.org/
   VERSION:=$(LINUX_VERSION)+$(PKG_VERSION)-$(BOARD)-$(PKG_RELEASE)