Message ID | 20200114150953.27659-23-alex.bennee@linaro.org |
---|---|
State | New |
Headers | show |
Series | gdbstub refactor and SVE support (+check-tcg tweaks) | expand |
On 1/14/20 5:09 AM, Alex Bennée wrote: > From: Damien Hedde <damien.hedde@greensocs.com> > > Since we can now send packets of arbitrary length: > simplify gdb_monitor_write() and send the whole payload > in one packet. > > Suggested-by: Luc Michel <luc.michel@greensocs.com> > Signed-off-by: Damien Hedde <damien.hedde@greensocs.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Message-Id: <20191211160514.58373-3-damien.hedde@greensocs.com> > --- > gdbstub.c | 23 +++-------------------- > 1 file changed, 3 insertions(+), 20 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/gdbstub.c b/gdbstub.c index b9fb8c0a95..6e461d871e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, QEMUChrEvent event) } } -static void gdb_monitor_output(const char *msg, int len) -{ - g_autoptr(GString) buf = g_string_new("O"); - memtohex(buf, (uint8_t *)msg, len); - put_packet(buf->str); -} - static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len) { - const char *p = (const char *)buf; - int max_sz; - - max_sz = (MAX_PACKET_LENGTH / 2) + 1; - for (;;) { - if (len <= max_sz) { - gdb_monitor_output(p, len); - break; - } - gdb_monitor_output(p, max_sz); - p += max_sz; - len -= max_sz; - } + g_autoptr(GString) hex_buf = g_string_new("O"); + memtohex(hex_buf, buf, len); + put_packet(hex_buf->str); return len; }