| Message ID | 20200114141647.109347-2-ardb@kernel.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | synquacer: add TPM support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, 14 Jan 2020 15:16:46 +0100, Ard Biesheuvel wrote: > Add a compatible string for the SynQuacer TPM to the binding for a > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > slightly differently on this hardware, so it requires its own > identifier. > > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 2020-01-14 at 15:16 +0100, Ard Biesheuvel wrote: > Add a compatible string for the SynQuacer TPM to the binding for a > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > slightly differently on this hardware, so it requires its own > identifier. > > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > --- > Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt b/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > index 7c6304426da1..b604c8688dc8 100644 > --- a/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > +++ b/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > @@ -12,6 +12,7 @@ Required properties: > - compatible: should contain a string below for the chip, followed by > "tcg,tpm-tis-mmio". Valid chip strings are: > * "atmel,at97sc3204" > + * "socionext,synquacer-tpm-mmio" > - reg: The location of the MMIO registers, should be at least 0x5000 bytes > - interrupts: An optional interrupt indicating command completion. > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Someone else needs to give reviewed-by as I am not expert on DT bindings. /Jarkko
On Thu, 23 Jan 2020 at 13:22, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > On Tue, 2020-01-14 at 15:16 +0100, Ard Biesheuvel wrote: > > Add a compatible string for the SynQuacer TPM to the binding for a > > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > > slightly differently on this hardware, so it requires its own > > identifier. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > > --- > > Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt b/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > > index 7c6304426da1..b604c8688dc8 100644 > > --- a/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > > +++ b/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt > > @@ -12,6 +12,7 @@ Required properties: > > - compatible: should contain a string below for the chip, followed by > > "tcg,tpm-tis-mmio". Valid chip strings are: > > * "atmel,at97sc3204" > > + * "socionext,synquacer-tpm-mmio" > > - reg: The location of the MMIO registers, should be at least 0x5000 bytes > > - interrupts: An optional interrupt indicating command completion. > > > > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > Someone else needs to give reviewed-by as I am not expert on DT bindings. > Cheers Jarko. Rob's ack should be sufficient for this to go via another tree. However, I am still waiting to hear back from Masahisa to confirm that the SPI command sequencer approach works 100% on this hardware, so shall we park these patches for the time being? Thanks, Ard.
diff --git a/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt b/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt index 7c6304426da1..b604c8688dc8 100644 --- a/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt +++ b/Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt @@ -12,6 +12,7 @@ Required properties: - compatible: should contain a string below for the chip, followed by "tcg,tpm-tis-mmio". Valid chip strings are: * "atmel,at97sc3204" + * "socionext,synquacer-tpm-mmio" - reg: The location of the MMIO registers, should be at least 0x5000 bytes - interrupts: An optional interrupt indicating command completion.
Add a compatible string for the SynQuacer TPM to the binding for a TPM exposed via a memory mapped TIS frame. The MMIO window behaves slightly differently on this hardware, so it requires its own identifier. Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Ard Biesheuvel <ardb@kernel.org> --- Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt | 1 + 1 file changed, 1 insertion(+)