[-next] gpio: Remove the unused flags
diff mbox series

Message ID 1579009062-7154-1-git-send-email-zhangshaokun@hisilicon.com
State New
Headers show
Series
  • [-next] gpio: Remove the unused flags
Related show

Commit Message

Shaokun Zhang Jan. 14, 2020, 1:37 p.m. UTC
drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
  unsigned long flags;
                 ^
Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org> 
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> 
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 drivers/gpio/gpio-grgpio.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bartosz Golaszewski Jan. 14, 2020, 2:10 p.m. UTC | #1
wt., 14 sty 2020 o 14:38 Shaokun Zhang <zhangshaokun@hisilicon.com> napisał(a):
>
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
>   unsigned long flags;
>                  ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Jia-Ju Bai Jan. 15, 2020, 1:34 a.m. UTC | #2
On 2020/1/14 21:37, Shaokun Zhang wrote:
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
>    unsigned long flags;
>                   ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>   drivers/gpio/gpio-grgpio.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index 1922adf96fc9..f954359c9544 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -435,7 +435,6 @@ static int grgpio_probe(struct platform_device *ofdev)
>   static int grgpio_remove(struct platform_device *ofdev)
>   {
>   	struct grgpio_priv *priv = platform_get_drvdata(ofdev);
> -	unsigned long flags;
>   	int i;
>   	int ret = 0;
>   

Reviewed-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Linus Walleij Jan. 15, 2020, 10:25 a.m. UTC | #3
On Tue, Jan 14, 2020 at 2:38 PM Shaokun Zhang
<zhangshaokun@hisilicon.com> wrote:

> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
>   unsigned long flags;
>                  ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>

Patch applied with the ACKs!

Thanks!
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index 1922adf96fc9..f954359c9544 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -435,7 +435,6 @@  static int grgpio_probe(struct platform_device *ofdev)
 static int grgpio_remove(struct platform_device *ofdev)
 {
 	struct grgpio_priv *priv = platform_get_drvdata(ofdev);
-	unsigned long flags;
 	int i;
 	int ret = 0;