syscalls/capget02: Use pid=0 instead of getpid()
diff mbox series

Message ID 1578553217-29510-1-git-send-email-xuyang2018.jy@cn.fujitsu.com
State Superseded
Delegated to: Petr Vorel
Headers show
Series
  • syscalls/capget02: Use pid=0 instead of getpid()
Related show

Commit Message

Yang Xu Jan. 9, 2020, 7 a.m. UTC
Since pid=0 returns the capabilities for the calling thread,
we can remove getpid and use pid=0 instead of it. Also we
can cover this test point.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 testcases/kernel/syscalls/capget/capget02.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Yang Xu Jan. 9, 2020, 7:24 a.m. UTC | #1
Hi
> Since pid=0 returns the capabilities for the calling thread,
> we can remove getpid and use pid=0 instead of it. Also we
> can cover this test point.
Since I defined static struct, I think it doesn't need pid=0 assignment. 
I will send a v2 and add comment.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>   testcases/kernel/syscalls/capget/capget02.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/capget/capget02.c b/testcases/kernel/syscalls/capget/capget02.c
> index 42c76a011..0a23700b9 100644
> --- a/testcases/kernel/syscalls/capget/capget02.c
> +++ b/testcases/kernel/syscalls/capget/capget02.c
> @@ -69,15 +69,13 @@ static void verify_capget(unsigned int n)
>   
>   static void setup(void)
>   {
> -	unsigned int i, pid;
> -
> -	pid = getpid();
> +	unsigned int i;
>   
>   	header.version = 0x19980330;
> -	header.pid = pid;
> +	header.pid = 0;
>   
>   	bad_version_header.version = 0;
> -	bad_version_header.pid = pid;
> +	bad_version_header.pid = 0;
>   
>   	bad_pid_header.version = 0x19980330;
>   	bad_pid_header.pid = -1;
>
Cyril Hrubis Jan. 9, 2020, 9:59 a.m. UTC | #2
Hi!
> > Since pid=0 returns the capabilities for the calling thread,
> > we can remove getpid and use pid=0 instead of it. Also we
> > can cover this test point.
> Since I defined static struct, I think it doesn't need pid=0 assignment. 
> I will send a v2 and add comment.

If you are at it, can you also allocate guarded buffers instead?

https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2231-guarded-buffers
Yang Xu Jan. 9, 2020, 10:14 a.m. UTC | #3
Hi!> Hi!
>>> Since pid=0 returns the capabilities for the calling thread,
>>> we can remove getpid and use pid=0 instead of it. Also we
>>> can cover this test point.
>> Since I defined static struct, I think it doesn't need pid=0 assignment.
>> I will send a v2 and add comment.
> 
> If you are at it, can you also allocate guarded buffers instead?
Sure, I will use guarded buffers instead.
> 
> https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2231-guarded-buffers
>
Petr Vorel Jan. 10, 2020, 4:46 p.m. UTC | #4
Hi,

FYI this was replaced by
https://patchwork.ozlabs.org/patch/1220805/
and merged as ad57b6090 syscalls/capget[set]: Make use of guarded buffers


Kind regards,
Petr
Yang Xu Jan. 13, 2020, 1:21 a.m. UTC | #5
Hi
> Hi,
> 
> FYI this was replaced by
> https://patchwork.ozlabs.org/patch/1220805/
> and merged as ad57b6090 syscalls/capget[set]: Make use of guarded buffers
> 
Thanks for your review and merge.

Best Regards
Yang Xu
> 
> Kind regards,
> Petr
> 
>

Patch
diff mbox series

diff --git a/testcases/kernel/syscalls/capget/capget02.c b/testcases/kernel/syscalls/capget/capget02.c
index 42c76a011..0a23700b9 100644
--- a/testcases/kernel/syscalls/capget/capget02.c
+++ b/testcases/kernel/syscalls/capget/capget02.c
@@ -69,15 +69,13 @@  static void verify_capget(unsigned int n)
 
 static void setup(void)
 {
-	unsigned int i, pid;
-
-	pid = getpid();
+	unsigned int i;
 
 	header.version = 0x19980330;
-	header.pid = pid;
+	header.pid = 0;
 
 	bad_version_header.version = 0;
-	bad_version_header.pid = pid;
+	bad_version_header.pid = 0;
 
 	bad_pid_header.version = 0x19980330;
 	bad_pid_header.pid = -1;