| Message ID | Pine.LNX.4.64.1110262113310.25943@digraph.polyomino.org.uk |
|---|---|
| State | New |
| Headers | show |
2011/10/26 Joseph S. Myers <joseph@codesourcery.com>: > The test gcc.dg/graphite/run-id-1.c requires more stack space than > Windows targets provide by default. This patch arranges for the > appropriate -Wl,--stack option (as in config/mh-mingw and > config/mh-cygwin) to be used by this test on those targets. Tested > with cross to i686-mingw32. OK to commit? > > 2011-10-26 Joseph Myers <joseph@codesourcery.com> > > * gcc.dg/graphite/run-id-1.c: Pass -Wl,--stack,12582912 option for > Windows targets. > > Index: gcc.dg/graphite/run-id-1.c > =================================================================== > --- gcc.dg/graphite/run-id-1.c (revision 180200) > +++ gcc.dg/graphite/run-id-1.c (working copy) > @@ -1,3 +1,4 @@ > +/* { dg-options "-Wl,--stack,12582912" { target *-*-mingw* *-*-cygwin* } } */ > /* { dg-require-effective-target size32plus } */ > > void abort (void); > > -- > Joseph S. Myers > joseph@codesourcery.com From my side patch is ok. Thanks, Kai
On Oct 26, 2011, at 2:17 PM, Joseph S. Myers wrote: > The test gcc.dg/graphite/run-id-1.c requires more stack space than > Windows targets provide by default. This patch arranges for the > appropriate -Wl,--stack option (as in config/mh-mingw and > config/mh-cygwin) to be used by this test on those targets. Tested > with cross to i686-mingw32. OK to commit? Yeah, I noticed these testcases (there were quite a few that hit me) on my port with a small stack. I fixed it by increasing my stack space for testing, so that I didn't have to go hit up testcase after testcase. I'm wondering if you would get better milage by just having this on the CFLAGS bits in dejagnu someplace, then at least, you'd never have to do this again. I'm fine with either fix you want to put in.
Index: gcc.dg/graphite/run-id-1.c =================================================================== --- gcc.dg/graphite/run-id-1.c (revision 180200) +++ gcc.dg/graphite/run-id-1.c (working copy) @@ -1,3 +1,4 @@ +/* { dg-options "-Wl,--stack,12582912" { target *-*-mingw* *-*-cygwin* } } */ /* { dg-require-effective-target size32plus } */ void abort (void);