Patchwork [U-Boot] devkit8000: Fix NAND SPL on boards with 256MB NAND

login
register
mail settings
Submitter Tom Rini
Date Oct. 26, 2011, 6:09 p.m.
Message ID <1319652551-31573-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/121958/
State Accepted
Commit c471ccb967508d579a4c0f0bff26fae4e7ab063e
Delegated to: Sandeep Paulraj
Headers show

Comments

Tom Rini - Oct. 26, 2011, 6:09 p.m.
The devkit8000 ships with either a 128MB or 256MB NAND chip.  In
order for SPL to work with 256MB NAND CONFIG_SYS_NAND_5_ADDR_CYCLE
needs to be set.  After talking with Scott Wood this should be
safe to set even for smaller NAND chips.

Cc: Scott Wood <scottwood@freescale.com>
Cc: Frederik Kriewitz <frederik@kriewitz.eu>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Tom Rini <trini@ti.com>
---
 include/configs/devkit8000.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Thomas Weber - Nov. 8, 2011, 8:53 p.m.
Am 26.10.2011 20:09, schrieb Tom Rini:
> The devkit8000 ships with either a 128MB or 256MB NAND chip.  In
> order for SPL to work with 256MB NAND CONFIG_SYS_NAND_5_ADDR_CYCLE
> needs to be set.  After talking with Scott Wood this should be
> safe to set even for smaller NAND chips.
>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Frederik Kriewitz <frederik@kriewitz.eu>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
>  include/configs/devkit8000.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
> index ba0d23e..1856aa9 100644
> --- a/include/configs/devkit8000.h
> +++ b/include/configs/devkit8000.h
> @@ -332,6 +332,7 @@
>  #define CONFIG_SPL_BSS_MAX_SIZE		0x80000
>  
>  /* NAND boot config */
> +#define CONFIG_SYS_NAND_5_ADDR_CYCLE
>  #define CONFIG_SYS_NAND_PAGE_COUNT	64
>  #define CONFIG_SYS_NAND_PAGE_SIZE	2048
>  #define CONFIG_SYS_NAND_OOBSIZE		64

Tested-by: Thomas Weber <weber@corscience.de>

on Devkit8000 with 256 MB NAND.

Tomorrow I will test it with a 128 MB NAND devkit8000.

Thomas
Thomas Weber - Nov. 9, 2011, 8:43 a.m.
Hello Tom,

Am 08.11.2011 21:53, schrieb Thomas Weber:
> Am 26.10.2011 20:09, schrieb Tom Rini:
>> The devkit8000 ships with either a 128MB or 256MB NAND chip.  In
>> order for SPL to work with 256MB NAND CONFIG_SYS_NAND_5_ADDR_CYCLE
>> needs to be set.  After talking with Scott Wood this should be
>> safe to set even for smaller NAND chips.
>>
>> Cc: Scott Wood <scottwood@freescale.com>
>> Cc: Frederik Kriewitz <frederik@kriewitz.eu>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Signed-off-by: Tom Rini <trini@ti.com>
>> ---
>>  include/configs/devkit8000.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
>> index ba0d23e..1856aa9 100644
>> --- a/include/configs/devkit8000.h
>> +++ b/include/configs/devkit8000.h
>> @@ -332,6 +332,7 @@
>>  #define CONFIG_SPL_BSS_MAX_SIZE		0x80000
>>  
>>  /* NAND boot config */
>> +#define CONFIG_SYS_NAND_5_ADDR_CYCLE
>>  #define CONFIG_SYS_NAND_PAGE_COUNT	64
>>  #define CONFIG_SYS_NAND_PAGE_SIZE	2048
>>  #define CONFIG_SYS_NAND_OOBSIZE		64
> 
> Tested-by: Thomas Weber <weber@corscience.de>
> 
> on Devkit8000 with 256 MB NAND.
> 
> Tomorrow I will test it with a 128 MB NAND devkit8000.
> 
> Thomas

Also on Devkit8000 with 128 MB NAND successful tested.

Thomas

Patch

diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index ba0d23e..1856aa9 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -332,6 +332,7 @@ 
 #define CONFIG_SPL_BSS_MAX_SIZE		0x80000
 
 /* NAND boot config */
+#define CONFIG_SYS_NAND_5_ADDR_CYCLE
 #define CONFIG_SYS_NAND_PAGE_COUNT	64
 #define CONFIG_SYS_NAND_PAGE_SIZE	2048
 #define CONFIG_SYS_NAND_OOBSIZE		64