| Message ID | 20200108100453.7476-1-markus.theil@tu-ilmenau.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] modules: fix undefined behavior | expand |
Thanks, both patches applied.
diff --git a/src/utils/utils_module_tests.c b/src/utils/utils_module_tests.c index b09225de0..f75d4065d 100644 --- a/src/utils/utils_module_tests.c +++ b/src/utils/utils_module_tests.c @@ -930,7 +930,7 @@ static int const_time_tests(void) { 0, 0 }, { 1, 0 }, { 2, 0 }, - { 1 << (sizeof(unsigned int) * 8 - 1), ~0 }, + { 1U << (sizeof(unsigned int) * 8 - 1), ~0 }, { ~0 - 1, ~0 }, { ~0, ~0 } }; @@ -941,7 +941,7 @@ static int const_time_tests(void) { 0, ~0 }, { 1, 0 }, { 2, 0 }, - { 1 << (sizeof(unsigned int) * 8 - 1), 0 }, + { 1U << (sizeof(unsigned int) * 8 - 1), 0 }, { ~0 - 1, 0 }, { ~0, 0 } };
Test: wpa_supplicant module tests ../src/utils/utils_module_tests.c:933:7: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> --- src/utils/utils_module_tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.24.1