From patchwork Wed Oct 26 14:22:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 121911 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3DC261007D2 for ; Thu, 27 Oct 2011 01:22:59 +1100 (EST) Received: from localhost ([::1]:32894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4Na-0001HL-6l for incoming@patchwork.ozlabs.org; Wed, 26 Oct 2011 10:22:54 -0400 Received: from eggs.gnu.org ([140.186.70.92]:50481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4NI-0000SX-Dm for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:22:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJ4ND-0008W7-Ts for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:22:36 -0400 Received: from mtagate1.uk.ibm.com ([194.196.100.161]:52846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4ND-0008Vg-KQ for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:22:31 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p9QEMU9f004548 for ; Wed, 26 Oct 2011 14:22:30 GMT Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9QEMURv2080984 for ; Wed, 26 Oct 2011 15:22:30 +0100 Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9QEMPTT031745 for ; Wed, 26 Oct 2011 15:22:26 +0100 Received: from localhost (sig-9-146-169-43.uk.ibm.com [9.146.169.43]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p9QEMPpv031734; Wed, 26 Oct 2011 15:22:25 +0100 From: Stefan Hajnoczi To: Date: Wed, 26 Oct 2011 15:22:08 +0100 Message-Id: <1319638933-19063-6-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1319638933-19063-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1319638933-19063-1-git-send-email-stefanha@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 194.196.100.161 Cc: Anthony Liguori , Stefan Hajnoczi , Pavel Borzenkov Subject: [Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Pavel Borzenkov 'ret' is unconditionally overwitten by qed_read_l1_table_sync() Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/qed.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/qed.c b/block/qed.c index 7fab155..e6720db 100644 --- a/block/qed.c +++ b/block/qed.c @@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags) if (ret < 0) { return ret; } - ret = 0; /* ret should always be 0 or -errno */ qed_header_le_to_cpu(&le_header, &s->header); if (s->header.magic != QED_MAGIC) {