Patchwork kvm: x86: Drop redundant apic base and tpr update from kvm_get_sregs

login
register
mail settings
Submitter Jan Kiszka
Date Oct. 26, 2011, 11:09 a.m.
Message ID <4EA7EA79.1090503@siemens.com>
Download mbox | patch
Permalink /patch/121881/
State New
Headers show

Comments

Jan Kiszka - Oct. 26, 2011, 11:09 a.m.
The latter was already commented out, the former is redundant as well.
We always get the latest changes after return from the guest via
kvm_arch_post_run.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 target-i386/kvm.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Marcelo Tosatti - Nov. 10, 2011, 2:59 p.m.
On Wed, Oct 26, 2011 at 01:09:45PM +0200, Jan Kiszka wrote:
> The latter was already commented out, the former is redundant as well.
> We always get the latest changes after return from the guest via
> kvm_arch_post_run.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied, thanks.

Patch

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index ddd115c..ffd6488 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1081,10 +1081,9 @@  static int kvm_get_sregs(CPUState *env)
     env->cr[3] = sregs.cr3;
     env->cr[4] = sregs.cr4;
 
-    cpu_set_apic_base(env->apic_state, sregs.apic_base);
-
     env->efer = sregs.efer;
-    //cpu_set_apic_tpr(env->apic_state, sregs.cr8);
+
+    /* changes to apic base and cr8/tpr are read back via kvm_arch_post_run */
 
 #define HFLAG_COPY_MASK \
     ~( HF_CPL_MASK | HF_PE_MASK | HF_MP_MASK | HF_EM_MASK | \