[2/2] PCI: vmd: Add device id for VMD device 8086:467F
diff mbox series

Message ID 20200106224122.3231-3-sushmax.kalakota@intel.com
State New
Headers show
Series
  • New VMD Device ids
Related show

Commit Message

Sushma Kalakota Jan. 6, 2020, 10:41 p.m. UTC
This patch adds support for this VMD device which supports the bus
restriction mode.

Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
---
 drivers/pci/controller/vmd.c | 2 ++
 include/linux/pci_ids.h      | 1 +
 2 files changed, 3 insertions(+)

Comments

Keith Busch Jan. 7, 2020, 7:13 p.m. UTC | #1
On Mon, Jan 06, 2020 at 03:41:22PM -0700, Sushma Kalakota wrote:
> This patch adds support for this VMD device which supports the bus
> restriction mode.

Suggested rephrasing to an imperative voice:

  Add new VMD device IDs that require the bus restriction mode.

> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>

The first sign-off should be the author, but there's no "From:" header
line for Jon. Is the attribution correct?

> @@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
>  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
>  		.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
>  				VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> +	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
> +		.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
>  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
>  		.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},

Since you know all the new device ids, might as well collapse this patch
with the first one from this series.
Derrick, Jonathan Jan. 7, 2020, 7:22 p.m. UTC | #2
Thanks Keith,

On Tue, 2020-01-07 at 12:13 -0700, Keith Busch wrote:
> On Mon, Jan 06, 2020 at 03:41:22PM -0700, Sushma Kalakota wrote:
> > This patch adds support for this VMD device which supports the bus
> > restriction mode.
> 
> Suggested rephrasing to an imperative voice:
> 
>   Add new VMD device IDs that require the bus restriction mode.
> 
Sure

> > Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> > Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
> 
> The first sign-off should be the author, but there's no "From:" header
> line for Jon. Is the attribution correct?
We both worked on this, though it was primarily Sushma.
We'll switch the attribution order per 
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin


> 
> > @@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
> >  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
> >  		.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
> >  				VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> > +	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
> > +		.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> >  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
> >  		.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> 
> Since you know all the new device ids, might as well collapse this patch
> with the first one from this series.
Sure

Patch
diff mbox series

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 2b192e72f550..9433bd387fdd 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -868,6 +868,8 @@  static const struct pci_device_id vmd_ids[] = {
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
 		.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
 				VMD_FEAT_HAS_BUS_RESTRICTIONS,},
+	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
+		.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
 		.driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
 	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B),
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 8b3bc4b545b9..aac007c60f87 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2957,6 +2957,7 @@ 
 #define PCI_DEVICE_ID_INTEL_SBRIDGE_BR		0x3cf5	/* 13.6 */
 #define PCI_DEVICE_ID_INTEL_SBRIDGE_SAD1	0x3cf6	/* 12.7 */
 #define PCI_DEVICE_ID_INTEL_IOAT_SNB	0x402f
+#define PCI_DEVICE_ID_INTEL_VMD_467F	0x467f
 #define PCI_DEVICE_ID_INTEL_VMD_4C3D	0x4c3d
 #define PCI_DEVICE_ID_INTEL_5100_16	0x65f0
 #define PCI_DEVICE_ID_INTEL_5100_19	0x65f3