[v4,20/20] usb: host: ehci-tegra: Remove unused fields from tegra_ehci_hcd
diff mbox series

Message ID 20200106013416.9604-21-digetx@gmail.com
State New
Headers show
Series
  • NVIDIA Tegra USB2 drivers clean up
Related show

Commit Message

Dmitry Osipenko Jan. 6, 2020, 1:34 a.m. UTC
There are few stale fields in tegra_ehci_hcd structure, let's remove them.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/usb/host/ehci-tegra.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Alan Stern Jan. 6, 2020, 3:16 p.m. UTC | #1
On Mon, 6 Jan 2020, Dmitry Osipenko wrote:

> There are few stale fields in tegra_ehci_hcd structure, let's remove them.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/usb/host/ehci-tegra.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 1eb94205a5ac..d6433f206c17 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -42,12 +42,10 @@ struct tegra_ehci_soc_config {
>  };
>  
>  struct tegra_ehci_hcd {
> -	struct tegra_usb_phy *phy;
>  	struct clk *clk;
>  	struct reset_control *rst;
>  	int port_resuming;
>  	bool needs_double_reset;
> -	enum tegra_usb_phy_port_speed port_speed;
>  };
>  
>  static int tegra_reset_usb_controller(struct platform_device *pdev)

For patches 2, 19, and 20:

Acked-by: Alan Stern <stern@rowland.harvard.edu>

It's nice to see that patch 2 makes the sequence of events in 
tegra_ehci_remove() exactly the same as the failure pathway in 
tegra_ehci_probe().

Alan Stern
Dmitry Osipenko Jan. 7, 2020, 4:13 p.m. UTC | #2
06.01.2020 18:16, Alan Stern пишет:
> On Mon, 6 Jan 2020, Dmitry Osipenko wrote:
> 
>> There are few stale fields in tegra_ehci_hcd structure, let's remove them.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/usb/host/ehci-tegra.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
>> index 1eb94205a5ac..d6433f206c17 100644
>> --- a/drivers/usb/host/ehci-tegra.c
>> +++ b/drivers/usb/host/ehci-tegra.c
>> @@ -42,12 +42,10 @@ struct tegra_ehci_soc_config {
>>  };
>>  
>>  struct tegra_ehci_hcd {
>> -	struct tegra_usb_phy *phy;
>>  	struct clk *clk;
>>  	struct reset_control *rst;
>>  	int port_resuming;
>>  	bool needs_double_reset;
>> -	enum tegra_usb_phy_port_speed port_speed;
>>  };
>>  
>>  static int tegra_reset_usb_controller(struct platform_device *pdev)
> 
> For patches 2, 19, and 20:
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> 
> It's nice to see that patch 2 makes the sequence of events in 
> tegra_ehci_remove() exactly the same as the failure pathway in 
> tegra_ehci_probe().

Thank you very much for taking a look at the patches!

Patch
diff mbox series

diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 1eb94205a5ac..d6433f206c17 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -42,12 +42,10 @@  struct tegra_ehci_soc_config {
 };
 
 struct tegra_ehci_hcd {
-	struct tegra_usb_phy *phy;
 	struct clk *clk;
 	struct reset_control *rst;
 	int port_resuming;
 	bool needs_double_reset;
-	enum tegra_usb_phy_port_speed port_speed;
 };
 
 static int tegra_reset_usb_controller(struct platform_device *pdev)