| Message ID | 20200103190632.1826-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] netdev-offload-tc: Fix using uninitialized recirc_act. | expand |
On 2020-01-03 9:06 PM, Ilya Maximets wrote: > Fixes: b2ae40690ed7 ("netdev-offload-tc: Add recirculation support via tc chains") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > lib/netdev-offload-tc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c > index 9e1c84d44..7453078d5 100644 > --- a/lib/netdev-offload-tc.c > +++ b/lib/netdev-offload-tc.c > @@ -1365,10 +1365,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match, > const struct flow_tnl *tnl = &match->flow.tunnel; > const struct flow_tnl *tnl_mask = &mask->tunnel; > struct tc_action *action; > + bool recirc_act = false; > uint32_t block_id = 0; > struct nlattr *nla; > struct tcf_id id; > - bool recirc_act; > uint32_t chain; > size_t left; > int prio = 0; > Acked-by: Roi Dayan <roid@mellanox.com>
On Sun, Jan 05, 2020 at 09:27:20AM +0000, Roi Dayan wrote: > > > On 2020-01-03 9:06 PM, Ilya Maximets wrote: > > Fixes: b2ae40690ed7 ("netdev-offload-tc: Add recirculation support via tc chains") > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > --- > > lib/netdev-offload-tc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c > > index 9e1c84d44..7453078d5 100644 > > --- a/lib/netdev-offload-tc.c > > +++ b/lib/netdev-offload-tc.c > > @@ -1365,10 +1365,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match, > > const struct flow_tnl *tnl = &match->flow.tunnel; > > const struct flow_tnl *tnl_mask = &mask->tunnel; > > struct tc_action *action; > > + bool recirc_act = false; > > uint32_t block_id = 0; > > struct nlattr *nla; > > struct tcf_id id; > > - bool recirc_act; > > uint32_t chain; > > size_t left; > > int prio = 0; > > > > Acked-by: Roi Dayan <roid@mellanox.com> Thanks, applied to master.
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 9e1c84d44..7453078d5 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -1365,10 +1365,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match, const struct flow_tnl *tnl = &match->flow.tunnel; const struct flow_tnl *tnl_mask = &mask->tunnel; struct tc_action *action; + bool recirc_act = false; uint32_t block_id = 0; struct nlattr *nla; struct tcf_id id; - bool recirc_act; uint32_t chain; size_t left; int prio = 0;
Fixes: b2ae40690ed7 ("netdev-offload-tc: Add recirculation support via tc chains") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- lib/netdev-offload-tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)