diff mbox series

Mark param_min_crossjump_insns with Optimization keyword.

Message ID 9f60f304-b4f0-89cd-c0b5-eef649b508d5@suse.cz
State New
Headers show
Series Mark param_min_crossjump_insns with Optimization keyword. | expand

Commit Message

Martin Liška Jan. 2, 2020, 11:06 a.m. UTC
Hi.

Again, the param is set based on optimize_size:

   if (opts->x_optimize_size)
     /* We want to crossjump as much as possible.  */
     SET_OPTION_IF_UNSET (opts, opts_set, param_min_crossjump_insns, 1);

So that, the param should be per-function. The only usage is in cfgcleanup
that is done per-function.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed?
Thanks,
Martin

gcc/ChangeLog:

2020-01-02  Martin Liska  <mliska@suse.cz>

	PR optimization/92860
	* params.opt: Mark param_min_crossjump_insns with Optimization
	keyword.
---
  gcc/params.opt | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Law Jan. 6, 2020, 4:19 p.m. UTC | #1
On Thu, 2020-01-02 at 12:06 +0100, Martin Liška wrote:
> Hi.
> 
> Again, the param is set based on optimize_size:
> 
>    if (opts->x_optimize_size)
>      /* We want to crossjump as much as possible.  */
>      SET_OPTION_IF_UNSET (opts, opts_set, param_min_crossjump_insns, 1);
> 
> So that, the param should be per-function. The only usage is in cfgcleanup
> that is done per-function.
> 
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> 
> Ready to be installed?
> Thanks,
> Martin
> 
> gcc/ChangeLog:
> 
> 2020-01-02  Martin Liska  <mliska@suse.cz>
> 
> 	PR optimization/92860
> 	* params.opt: Mark param_min_crossjump_insns with Optimization
> 	keyword.
OK
jeff
diff mbox series

Patch

diff --git a/gcc/params.opt b/gcc/params.opt
index 6f05b29a929..2b86fae307a 100644
--- a/gcc/params.opt
+++ b/gcc/params.opt
@@ -667,7 +667,7 @@  Common Joined UInteger Var(param_max_vrp_switch_assertions) Init(10) Param
 Maximum number of assertions to add along the default edge of a switch statement during VRP.
 
 -param=min-crossjump-insns=
-Common Joined UInteger Var(param_min_crossjump_insns) Init(5) IntegerRange(1, 65536) Param
+Common Joined UInteger Var(param_min_crossjump_insns) Init(5) IntegerRange(1, 65536) Param Optimization
 The minimum number of matching instructions to consider for crossjumping.
 
 -param=min-inline-recursive-probability=