diff mbox series

[OpenWrt-Devel,1/2] scripts/gen-dependencies.sh: replace backticks with $()

Message ID 20200101020628.21503-1-rosenp@gmail.com
State Accepted
Headers show
Series [OpenWrt-Devel,1/2] scripts/gen-dependencies.sh: replace backticks with $() | expand

Commit Message

Rosen Penev Jan. 1, 2020, 2:06 a.m. UTC 
Found with shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 scripts/gen-dependencies.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jo-Philipp Wich Jan. 1, 2020, 4 p.m. UTC | #1 
Merged into master at
http://git.openwrt.org/?p=openwrt/openwrt.git.

Thank you!
diff mbox series

Patch

diff --git a/scripts/gen-dependencies.sh b/scripts/gen-dependencies.sh
index 0aa01b78ec..01bb5ac037 100755
--- a/scripts/gen-dependencies.sh
+++ b/scripts/gen-dependencies.sh
@@ -24,8 +24,8 @@  find $TARGETS -type f -a -exec file {} \; | \
   awk '$2 ~ /NEEDED/ && $NF !~ /interpreter/ && $NF ~ /^\[?lib.*\.so/ { gsub(/[\[\]]/, "", $NF); print $NF }' | \
   sort -u
 
-tmp=`mktemp $TMP_DIR/dep.XXXXXXXX`
-for kmod in `find $TARGETS -type f -name \*.ko`; do
+tmp=$(mktemp $TMP_DIR/dep.XXXXXXXX)
+for kmod in $(find $TARGETS -type f -name \*.ko); do
 	$OBJCOPY -O binary -j .modinfo $kmod $tmp
 	sed -e 's,\x00,\n,g' $tmp | \
 		sed -ne '/^depends=.\+/ { s/^depends=//; s/,/.ko\n/g; s/$/.ko/p; q }'