diff mbox series

[OpenWrt-Devel] scripts/env: use command -v instead of which

Message ID 20200101020331.21280-1-rosenp@gmail.com
State Superseded
Headers show
Series [OpenWrt-Devel] scripts/env: use command -v instead of which | expand

Commit Message

Rosen Penev Jan. 1, 2020, 2:03 a.m. UTC 
Simpler and built in to the shell.

Found with shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 scripts/env | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/scripts/env b/scripts/env
index 84166ae5fe..69b63895b4 100755
--- a/scripts/env
+++ b/scripts/env
@@ -57,7 +57,7 @@  env_init() {
 	if [ -z "$CREATE" ]; then
 		[ -d "$ENVDIR" ] || exit 0
 	fi
-	[ -x "$(which git 2>/dev/null)" ] || error "Git is not installed"
+	command -v git || error "Git is not installed"
 	mkdir -p "$ENVDIR" || error "Failed to create the environment directory"
 	cd "$ENVDIR" || error "Failed to switch to the environment directory"
 	[ -d .git ] || {