| Message ID | 1319548630-6561-1-git-send-email-Joakim.Tjernlund@transmode.se |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> Date: Tue, 25 Oct 2011 15:17:10 +0200 > In a busy network we see ucc_geth is dropping RX pkgs every now > and then. Increase the first RX queues HW descriptors from > 16 to 32 to deal with this. > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> 1) This patch doesn't apply, because in the current tree this dirver lives under drivers/net/ethernet/freescale/ not drivers/net 2) Why not increase RX_BD_RING_LEN and thus all the ring sizes, is there a special reason only the first ring's size should be increased? Because the way you've made this change is confusing, someone will see RX_BD_RING_LEN's definition and believe that this is the size of the primary ring unless they happen to notice how .bdRingLenRx is initialized in this special way. Thus, this patch needs changes before it can even be considered for inclusion. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index fa00935..04e22ff 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c @@ -134,7 +134,7 @@ static struct ucc_geth_info ugeth_primary_info = { TX_BD_RING_LEN}, .bdRingLenRx = { - RX_BD_RING_LEN, + RX_BD_RING_LEN*2, RX_BD_RING_LEN, RX_BD_RING_LEN, RX_BD_RING_LEN,
In a busy network we see ucc_geth is dropping RX pkgs every now and then. Increase the first RX queues HW descriptors from 16 to 32 to deal with this. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> --- drivers/net/ucc_geth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)