| Message ID | 20191231134644.28119-1-geert+renesas@glider.be |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | of: overlay: Remove blank line between assignment and check | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 7 lines checked" |
On Tue, 31 Dec 2019 14:46:44 +0100, Geert Uytterhoeven wrote: > There used to be blank lines between assignment and check of the > __of_changeset_revert_entries() result, to make the phandle cache > management operations stand out. After the removal of those operations > in commit 90dc0d1ce890419f ("of: Rework and simplify phandle cache to > use a fixed size"), there is no longer a reason to have such a blank > line. > > Remove the blank line, to rejoin visibly the status assignement and > check, and to match coding style. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/of/overlay.c | 1 - > 1 file changed, 1 deletion(-) > Applied, thanks. Rob
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 788ab3501913d04f..87ef7cdfd0381799 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -1391,7 +1391,6 @@ int of_overlay_remove(int *ovcs_id) ret_apply = 0; ret = __of_changeset_revert_entries(&ovcs->cset, &ret_apply); - if (ret) { if (ret_apply) devicetree_state_flags |= DTSF_REVERT_FAIL;
There used to be blank lines between assignment and check of the __of_changeset_revert_entries() result, to make the phandle cache management operations stand out. After the removal of those operations in commit 90dc0d1ce890419f ("of: Rework and simplify phandle cache to use a fixed size"), there is no longer a reason to have such a blank line. Remove the blank line, to rejoin visibly the status assignement and check, and to match coding style. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/of/overlay.c | 1 - 1 file changed, 1 deletion(-)