diff mbox series

[OpenWrt-Devel,1/2] scripts/flashing: Switch from echo -en to printf

Message ID 20191231021626.47613-1-rosenp@gmail.com
State Superseded
Headers show
Series [OpenWrt-Devel,1/2] scripts/flashing: Switch from echo -en to printf | expand

Commit Message

Rosen Penev Dec. 31, 2019, 2:16 a.m. UTC 
echo flags are an extension and not available with sh. printf does the
same as -en.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 scripts/flashing/flash.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Jo-Philipp Wich Jan. 1, 2020, 4:07 p.m. UTC | #1 
Hi.

$ patch -p1 < 1216552.patch
patching file scripts/flashing/flash.sh
Hunk #1 FAILED at 51.
1 out of 1 hunk FAILED -- saving rejects to file
scripts/flashing/flash.sh.rej

~ Jo
Rosen Penev Jan. 1, 2020, 11:05 p.m. UTC | #2 
On Wed, Jan 1, 2020 at 8:07 AM Jo-Philipp Wich <jo@mein.io> wrote:
>
> Hi.
>
> $ patch -p1 < 1216552.patch
> patching file scripts/flashing/flash.sh
> Hunk #1 FAILED at 51.
> 1 out of 1 hunk FAILED -- saving rejects to file
> scripts/flashing/flash.sh.rej
will resend.
>
> ~ Jo
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh
index 7f2cdf5db9..aea1bf1568 100755
--- a/scripts/flashing/flash.sh
+++ b/scripts/flashing/flash.sh
@@ -51,16 +51,16 @@  EOF
 fi
 if [ "$2" = "asus" ]; then
 echo Confirming IP address setting...
-echo -en "get ASUSSPACELINK\x01\x01\xa8\xc0 /dev/null\nquit\n" | tftp 192.168.1.1
+printf "get ASUSSPACELINK\x01\x01\xa8\xc0 /dev/null\nquit\n" | tftp 192.168.1.1
 echo Flashing 192.168.1.1 using "$1"...
-echo -en "binary\nput $1 ASUSSPACELINK\nquit\n" | tftp 192.168.1.1
+printf "binary\nput %s ASUSSPACELINK\nquit\n" "$1" | tftp 192.168.1.1
 echo Please wait until leds stops flashing. 
 elif [ "$2" = "linksys" ]; then
 echo Flashing 192.168.1.1 using "$1"...
-echo -en "rexmt 1\ntrace\nbinary\nput $1\nquit\n" | tftp 192.168.1.1
+printf "rexmt 1\ntrace\nbinary\nput %s\nquit\n" "$1" | tftp 192.168.1.1
 echo Please wait until power led stops flashing. Do not poweroff! Then you can login via telnet 192.168.1.1.
 elif [ "$2" = "toshiba" ]; then
 echo Flashing 192.168.10.1 using "$1"...
-echo -en "rexmt 1\ntrace\nbinary\nput $1\nquit\n" | tftp 192.168.10.1
+printf "rexmt 1\ntrace\nbinary\nput %s\nquit\n" "$1" | tftp 192.168.10.1
 echo Unit will automatically reboot within 5 minutes.  Do not power off.  Then you can login via telnet 192.168.10.1.
 fi