| Message ID | 1577674960-12011-1-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: imx27: Eliminate error message for defer probe | expand |
On Mon, Dec 30, 2019 at 11:02:40AM +0800, Anson Huang wrote: > For defer probe error, no need to output error message which > will cause confusion. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > drivers/pwm/pwm-imx27.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index 59d8b12..35a7ac42 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -319,9 +319,13 @@ static int pwm_imx27_probe(struct platform_device *pdev) > > imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(imx->clk_ipg)) { > - dev_err(&pdev->dev, "getting ipg clock failed with %ld\n", > - PTR_ERR(imx->clk_ipg)); > - return PTR_ERR(imx->clk_ipg); > + int ret = PTR_ERR(imx->clk_ipg); > + > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "getting ipg clock failed with %d\n", > + ret); While you touch this part, you could convert to %pe to get a more expressive error message. But even independent of this the patch is fine, so Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index 59d8b12..35a7ac42 100644 --- a/drivers/pwm/pwm-imx27.c +++ b/drivers/pwm/pwm-imx27.c @@ -319,9 +319,13 @@ static int pwm_imx27_probe(struct platform_device *pdev) imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); if (IS_ERR(imx->clk_ipg)) { - dev_err(&pdev->dev, "getting ipg clock failed with %ld\n", - PTR_ERR(imx->clk_ipg)); - return PTR_ERR(imx->clk_ipg); + int ret = PTR_ERR(imx->clk_ipg); + + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "getting ipg clock failed with %d\n", + ret); + return ret; } imx->clk_per = devm_clk_get(&pdev->dev, "per");
For defer probe error, no need to output error message which will cause confusion. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/pwm/pwm-imx27.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)