diff mbox series

usb: phy: phy-gpio-vbus-usb: fix odd_ptr_err.cocci warnings

Message ID alpine.DEB.2.21.1912282237590.2578@hadrien
State New
Headers show
Series usb: phy: phy-gpio-vbus-usb: fix odd_ptr_err.cocci warnings | expand

Commit Message

Julia Lawall Dec. 28, 2019, 9:39 p.m. UTC 
From: kbuild test robot <lkp@intel.com>

Inconsistent IS_ERR and PTR_ERR on line 291.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: ec84cd4d1bb8 ("usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git gpio-descriptors-usb
head:   ec84cd4d1bb85874b0ed3f5e4e567fb2ccb956bd
commit: ec84cd4d1bb85874b0ed3f5e4e567fb2ccb956bd [6/6] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago

 phy-gpio-vbus-usb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

--- a/drivers/usb/phy/phy-gpio-vbus-usb.c
+++ b/drivers/usb/phy/phy-gpio-vbus-usb.c
@@ -288,7 +288,7 @@  static int gpio_vbus_probe(struct platfo
 	gpio_vbus->pullup_gpiod = devm_gpiod_get_optional(dev, "pullup",
 							  GPIOD_OUT_LOW);
 	if (IS_ERR(gpio_vbus->pullup_gpiod)) {
-		err = PTR_ERR(gpio_vbus->vbus_gpiod);
+		err = PTR_ERR(gpio_vbus->pullup_gpiod);
 		dev_err(&pdev->dev, "can't request pullup gpio, err: %d\n",
 			err);
 		return err;