Patchwork [U-Boot,07/18] GCC4.6: Squash warnings in fsl_pci_init.c

login
register
mail settings
Submitter Marek Vasut
Date Oct. 25, 2011, 9:39 a.m.
Message ID <1319535604-20831-8-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/121549/
State Accepted
Headers show

Comments

Marek Vasut - Oct. 25, 2011, 9:39 a.m.
fsl_pci_init.c: In function 'fsl_pci_init':
fsl_pci_init.c:308: warning: format '%08x' expects type 'unsigned int', but
argument 6 has type 'long unsigned int'
fsl_pci_init.c:347: warning: format '%x' expects type 'unsigned int', but
argument 2 has type 'volatile u32 *'

fsl_pci_init.c: In function 'fsl_pci_init':
fsl_pci_init.c:308: warning: format '%016llx' expects type 'long long unsigned
int', but argument 4 has type 'pci_addr_t'
fsl_pci_init.c:308: warning: format '%016llx' expects type 'long long unsigned
int', but argument 5 has type 'pci_size_t'
fsl_pci_init.c:308: warning: format '%08x' expects type 'unsigned int', but
argument 6 has type 'long unsigned int'

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Mike Frysinger <vapier@gentoo.org>
---
 drivers/pci/fsl_pci_init.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Wolfgang Denk - Oct. 27, 2011, 9:59 p.m.
Dear Marek Vasut,

In message <1319535604-20831-8-git-send-email-marek.vasut@gmail.com> you wrote:
> fsl_pci_init.c: In function 'fsl_pci_init':
> fsl_pci_init.c:308: warning: format '%08x' expects type 'unsigned int', but
> argument 6 has type 'long unsigned int'
> fsl_pci_init.c:347: warning: format '%x' expects type 'unsigned int', but
> argument 2 has type 'volatile u32 *'
> 
> fsl_pci_init.c: In function 'fsl_pci_init':
> fsl_pci_init.c:308: warning: format '%016llx' expects type 'long long unsigned
> int', but argument 4 has type 'pci_addr_t'
> fsl_pci_init.c:308: warning: format '%016llx' expects type 'long long unsigned
> int', but argument 5 has type 'pci_size_t'
> fsl_pci_init.c:308: warning: format '%08x' expects type 'unsigned int', but
> argument 6 has type 'long unsigned int'
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/pci/fsl_pci_init.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/pci/fsl_pci_init.c b/drivers/pci/fsl_pci_init.c
index 7f601d4..bff1314 100644
--- a/drivers/pci/fsl_pci_init.c
+++ b/drivers/pci/fsl_pci_init.c
@@ -305,10 +305,10 @@  void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
 	inbound = fsl_pci_setup_inbound_windows(hose, out_lo, pcie_cap, pi);
 
 	for (r = 0; r < hose->region_count; r++)
-		debug("PCI reg:%d %016llx:%016llx %016llx %08x\n", r,
+		debug("PCI reg:%d %016llx:%016llx %016llx %08lx\n", r,
 			(u64)hose->regions[r].phys_start,
-			hose->regions[r].bus_start,
-			hose->regions[r].size,
+			(u64)hose->regions[r].bus_start,
+			(u64)hose->regions[r].size,
 			hose->regions[r].flags);
 
 	pci_register_hose(hose);
@@ -344,7 +344,7 @@  void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
 			setbits_be32(&pci->pdb_stat, 0x08000000);
 			(void) in_be32(&pci->pdb_stat);
 			udelay(100);
-			debug("  Asserting PCIe reset @%x = %x\n",
+			debug("  Asserting PCIe reset @%p = %x\n",
 			      &pci->pdb_stat, in_be32(&pci->pdb_stat));
 			/* clear PCIe reset */
 			clrbits_be32(&pci->pdb_stat, 0x08000000);