Patchwork [U-Boot,06/18] GCC4.6: Squash warnings in fsl_espi.c

login
register
mail settings
Submitter Marek Vasut
Date Oct. 25, 2011, 9:39 a.m.
Message ID <1319535604-20831-7-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/121547/
State Accepted
Headers show

Comments

Marek Vasut - Oct. 25, 2011, 9:39 a.m.
fsl_espi.c: In function 'spi_setup_slave':
fsl_espi.c:100: warning: format '%d' expects type 'int', but argument 3 has type
'long unsigned int'
fsl_espi.c: In function 'spi_xfer':
fsl_espi.c:237: warning: format '%08x' expects type 'unsigned int', but argument
5 has type 'const void *'
fsl_espi.c:237: warning: format '%08x' expects type 'unsigned int', but argument
7 has type 'void *'

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Mike Frysinger <vapier@gentoo.org>
---
 drivers/spi/fsl_espi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Wolfgang Denk - Oct. 27, 2011, 9:59 p.m.
Dear Marek Vasut,

In message <1319535604-20831-7-git-send-email-marek.vasut@gmail.com> you wrote:
> fsl_espi.c: In function 'spi_setup_slave':
> fsl_espi.c:100: warning: format '%d' expects type 'int', but argument 3 has type
> 'long unsigned int'
> fsl_espi.c: In function 'spi_xfer':
> fsl_espi.c:237: warning: format '%08x' expects type 'unsigned int', but argument
> 5 has type 'const void *'
> fsl_espi.c:237: warning: format '%08x' expects type 'unsigned int', but argument
> 7 has type 'void *'
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/spi/fsl_espi.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c
index f872cd8..a1ebd33 100644
--- a/drivers/spi/fsl_espi.c
+++ b/drivers/spi/fsl_espi.c
@@ -97,8 +97,8 @@  struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
 		pm = spibrg / (max_hz * 16 * 2);
 		if (pm > 16) {
 			pm = 16;
-			debug("Requested speed is too low: %d Hz, "
-				"%d Hz is used.\n", max_hz, spibrg / (32 * 16));
+			debug("Requested speed is too low: %d Hz, %ld Hz "
+				"is used.\n", max_hz, spibrg / (32 * 16));
 		}
 	} else
 		pm = spibrg / (max_hz * 2);
@@ -234,7 +234,7 @@  int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *data_out,
 		break;
 	}
 
-	debug("spi_xfer: slave %u:%u dout %08X(%08x) din %08X(%08x) len %u\n",
+	debug("spi_xfer: slave %u:%u dout %08X(%p) din %08X(%p) len %u\n",
 	      slave->bus, slave->cs, *(uint *) dout,
 	      dout, *(uint *) din, din, len);