| Message ID | 20191224164820.14245-1-fercerpav@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [OpenWrt-Devel] ath79: tp-link: use ath10k-ct-smallbuffers for 64 MiB devices | expand |
Hi, Answers inline. W dniu 2019-12-24 o 20:47, Paul Fertser pisze: > Hi Lech, > > Any reason you omit the list from Cc? This way nobody but me is going > to comment on your message and I'm obviously biased :) Just forgot to use "reply to all". > > On Tue, Dec 24, 2019 at 08:26:09PM +0100, Lech Perczak wrote: >> I think that TL-WR902AC v1 should be included as well, as it is 64M device >> and I also experienced issues with ath10k-ct on it while porting. > Device like that requires the tweak, no doubt. But I'm not feeling > like going through the whole ar71xx target since it's deprecated > anyway and whoever cares should port the needed boards to ath79 AFAIK. > > So if one stays on ar71xx for the upcoming release the workaround > would be to manually run > > opkg remove kmod-ath10k-ct && opkg install kmod-ath10k-ct-smallbuffers > > That said, I have no idea if patches to ar71xx are accepted or not. > This device was just ported to ath79 recently. I think grepping by device trees could be used to determine devices which need the changes. -- With kind regards, Lech
On Tue, Dec 24, 2019 at 09:27:21PM +0100, Lech Perczak wrote: > > On Tue, Dec 24, 2019 at 08:26:09PM +0100, Lech Perczak wrote: > > > I think that TL-WR902AC v1 should be included as well, as it is 64M device > > > and I also experienced issues with ath10k-ct on it while porting. > > Device like that requires the tweak, no doubt. But I'm not feeling > > like going through the whole ar71xx target since it's deprecated > > anyway and whoever cares should port the needed boards to ath79 AFAIK. > > > This device was just ported to ath79 recently. Indeed, it got right in-between. I'll send an amendment to this tp-link patch, thanks for noticing! > I think grepping by device trees could be used to determine devices which > need the changes. I have an impression that RAM amount is autodetected, so grepping through DTSes can't help here. In any case, I think it's all covered by now. Thank you!
diff --git a/target/linux/ath79/image/generic-tp-link.mk b/target/linux/ath79/image/generic-tp-link.mk index 8a030492c5..f4e16e6e43 100644 --- a/target/linux/ath79/image/generic-tp-link.mk +++ b/target/linux/ath79/image/generic-tp-link.mk @@ -195,8 +195,8 @@ define Device/tplink_archer-d50-v1 DEVICE_VENDOR := TP-Link DEVICE_MODEL := Archer D50 DEVICE_VARIANT := v1 - DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct \ - ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport \ + kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct BOARDNAME := ARCHER-D50-V1 IMAGE_SIZE := 7808k TPLINK_HWID := 0xC1200001 @@ -366,7 +366,7 @@ define Device/tplink_re450-v2 IMAGE_SIZE := 6016k DEVICE_MODEL := RE450 DEVICE_VARIANT := v2 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct TPLINK_HWID := 0x0 TPLINK_HWREV := 0 TPLINK_BOARD_ID := RE450-V2
Signed-off-by: Paul Fertser <fercerpav@gmail.com> --- target/linux/ath79/image/generic-tp-link.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)