net: make bonding slaves honour master's skb->priority

From: Maciej Żenczykowski <maze@google.com>

Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 drivers/net/bonding/bond_main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

On Mon, 24 Oct 2011 22:04:16 -0700
Maciej Żenczykowski <zenczykowski@gmail.com> wrote:

> From: Maciej Żenczykowski <maze@google.com>
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
>  drivers/net/bonding/bond_main.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c
> b/drivers/net/bonding/bond_main.c index 41430ba..2cbc2f8 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond,
> struct sk_buff *skb, struct net_device *slave_dev)
>  {
>  	skb->dev = slave_dev;
> -	skb->priority = 1;
>  
>  	skb->queue_mapping = bond_queue_mapping(skb);
>  

I tripped on it few times and never understood why we
were fixing the priority at this point.
thanks,

Acked-by: Flavio Leitner <fbl@redhat.com>
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

> I tripped on it few times and never understood why we
> were fixing the priority at this point.
> thanks,

It looks like ancient code, going all the way back to something like
Linux 2.4.14 (if I recall my git blame session correctly).
I can't think of a good reason for this...

- Maciej
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Maciej Żenczykowski <zenczykowski@gmail.com> wrote:

>> I tripped on it few times and never understood why we
>> were fixing the priority at this point.
>> thanks,
>
>It looks like ancient code, going all the way back to something like
>Linux 2.4.14 (if I recall my git blame session correctly).
>I can't think of a good reason for this...

	I believe this line goes back to the beginning, prior to git or
bk.  The skb->priority probably meant something different than it does
today.

	In any event, I'm fine with the code change.  There's still no
actual log message, but if Davem is ok with that I'm ok with it, given
the trivial nature of the change.

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Tue, 25 Oct 2011 09:45:35 -0700

> Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
> 
>>> I tripped on it few times and never understood why we
>>> were fixing the priority at this point.
>>> thanks,
>>
>>It looks like ancient code, going all the way back to something like
>>Linux 2.4.14 (if I recall my git blame session correctly).
>>I can't think of a good reason for this...
> 
> 	I believe this line goes back to the beginning, prior to git or
> bk.  The skb->priority probably meant something different than it does
> today.
> 
> 	In any event, I'm fine with the code change.  There's still no
> actual log message, but if Davem is ok with that I'm ok with it, given
> the trivial nature of the change.
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html