diff mbox series

DPP: Fix a memory leak

Message ID 20191220192128.85524-1-alexander@wetzel-home.de
State Accepted
Headers show
Series DPP: Fix a memory leak | expand

Commit Message

Alexander Wetzel Dec. 20, 2019, 7:21 p.m. UTC 
Fix a memory leak exposed by the dpp_own_config_sign_fail test.

Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de>
---
 src/common/dpp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Jouni Malinen Dec. 21, 2019, 3:50 p.m. UTC | #1 
On Fri, Dec 20, 2019 at 08:21:25PM +0100, Alexander Wetzel wrote:
> Fix a memory leak exposed by the dpp_own_config_sign_fail test.

Thanks, applied.
diff mbox series

Patch

diff --git a/src/common/dpp.c b/src/common/dpp.c
index 0d0c47ec8..fce4c1d66 100644
--- a/src/common/dpp.c
+++ b/src/common/dpp.c
@@ -6859,8 +6859,10 @@  int dpp_configurator_own_config(struct dpp_authentication *auth,
 	dpp_copy_csign(&auth->conf_obj[0], auth->conf->csign);
 
 	conf_obj = dpp_build_conf_obj(auth, ap, 0);
-	if (!conf_obj)
+	if (!conf_obj) {
+		wpabuf_free(auth->conf_obj[0].c_sign_key);
 		goto fail;
+	}
 	ret = dpp_parse_conf_obj(auth, wpabuf_head(conf_obj),
 				 wpabuf_len(conf_obj));
 fail: