Patchwork [v3] add missing dg-require to tests

login
register
mail settings
Submitter Jonathan Wakely
Date Oct. 24, 2011, 7:11 p.m.
Message ID <CAH6eHdRugSF+vLM0-yLyJrc-BVWg4dg2VHZnONmCMH2mqLCZww@mail.gmail.com>
Download mbox | patch
Permalink /patch/121396/
State New
Headers show

Comments

Jonathan Wakely - Oct. 24, 2011, 7:11 p.m.
http://gcc.gnu.org/ml/gcc-testresults/2011-10/msg02603.html shows two
test failures on sparc64-linux, fixed by this patch.

Tested x86_64-linux and committed to trunk.

        * testsuite/30_threads/async/49668.cc: Add missing dg-require.
        * testsuite/30_threads/packaged_task/49668.cc: Likewise.
Eric Botcazou - Nov. 7, 2011, 8:58 p.m.
> Tested x86_64-linux and committed to trunk.
>
>         * testsuite/30_threads/async/49668.cc: Add missing dg-require.
>         * testsuite/30_threads/packaged_task/49668.cc: Likewise.

We have a related failure on SPARC/Solaris for some time:

FAIL: 30_threads/call_once/49668.cc (test for excess errors)
WARNING: 30_threads/call_once/49668.cc compilation failed to produce executable

[...]
/nile.build/botcazou/gcc-head/sparc-sun-solaris2.8/sparc-sun-solaris2.8/libstdc\
++-v3/include/tuple:105:12: error: use of deleted 
function 'moveable::moveable(const moveable&)'
/nile.build/botcazou/gcc-head/src/libstdc++-v3/testsuite/30_threads/call_once/49668.cc

It can be reproduced with a cross-compiler targetting sparc-sun-solaris2.9 and 
the .ii file.  I can open a PR if you want.
Jonathan Wakely - Nov. 7, 2011, 9:05 p.m.
On 7 November 2011 20:58, Eric Botcazou wrote:
>> Tested x86_64-linux and committed to trunk.
>>
>>         * testsuite/30_threads/async/49668.cc: Add missing dg-require.
>>         * testsuite/30_threads/packaged_task/49668.cc: Likewise.
>
> We have a related failure on SPARC/Solaris for some time:
>
> FAIL: 30_threads/call_once/49668.cc (test for excess errors)
> WARNING: 30_threads/call_once/49668.cc compilation failed to produce executable
>
> [...]
> /nile.build/botcazou/gcc-head/sparc-sun-solaris2.8/sparc-sun-solaris2.8/libstdc\
> ++-v3/include/tuple:105:12: error: use of deleted
> function 'moveable::moveable(const moveable&)'
> /nile.build/botcazou/gcc-head/src/libstdc++-v3/testsuite/30_threads/call_once/49668.cc
>
> It can be reproduced with a cross-compiler targetting sparc-sun-solaris2.9 and
> the .ii file.  I can open a PR if you want.

I'll look into it - thanks
Jonathan Wakely - Nov. 7, 2011, 9:51 p.m.
On 7 November 2011 21:05, Jonathan Wakely wrote:
> On 7 November 2011 20:58, Eric Botcazou wrote:
>>> Tested x86_64-linux and committed to trunk.
>>>
>>>         * testsuite/30_threads/async/49668.cc: Add missing dg-require.
>>>         * testsuite/30_threads/packaged_task/49668.cc: Likewise.
>>
>> We have a related failure on SPARC/Solaris for some time:
>>
>> FAIL: 30_threads/call_once/49668.cc (test for excess errors)
>> WARNING: 30_threads/call_once/49668.cc compilation failed to produce executable
>>
>> [...]
>> /nile.build/botcazou/gcc-head/sparc-sun-solaris2.8/sparc-sun-solaris2.8/libstdc\
>> ++-v3/include/tuple:105:12: error: use of deleted
>> function 'moveable::moveable(const moveable&)'
>> /nile.build/botcazou/gcc-head/src/libstdc++-v3/testsuite/30_threads/call_once/49668.cc
>>
>> It can be reproduced with a cross-compiler targetting sparc-sun-solaris2.9 and
>> the .ii file.  I can open a PR if you want.
>
> I'll look into it - thanks
>

Aha, this is a problem with all platforms where _GLIBCXX_HAVE_TLS is
not defined, std::call_once uses std:function which assumes a copyable
target object.

I'm working on it ..

Patch

Index: testsuite/30_threads/async/49668.cc
===================================================================
--- testsuite/30_threads/async/49668.cc	(revision 180359)
+++ testsuite/30_threads/async/49668.cc	(working copy)
@@ -4,6 +4,7 @@ 
 // { dg-options " -std=gnu++0x " { target *-*-cygwin *-*-darwin* } }
 // { dg-require-cstdint "" }
 // { dg-require-gthreads "" }
+// { dg-require-atomic-builtins "" }
 
 // Copyright (C) 2011 Free Software Foundation, Inc.
 //
Index: testsuite/30_threads/packaged_task/49668.cc
===================================================================
--- testsuite/30_threads/packaged_task/49668.cc	(revision 180359)
+++ testsuite/30_threads/packaged_task/49668.cc	(working copy)
@@ -4,6 +4,7 @@ 
 // { dg-options " -std=gnu++0x " { target *-*-cygwin *-*-darwin* } }
 // { dg-require-cstdint "" }
 // { dg-require-gthreads "" }
+// { dg-require-atomic-builtins "" }
 
 // Copyright (C) 2011 Free Software Foundation, Inc.
 //