Patchwork [v3,1/2] dp83640: use proper function to free transmit time stamping packets

mail settings
Submitter Richard Cochran
Date Oct. 24, 2011, 5:55 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/121387/
State Not Applicable
Delegated to: David Miller
Headers show


Richard Cochran - Oct. 24, 2011, 5:55 p.m.
Commit da92b194 introduced a new rule for handling the cloned packets
for transmit time stamping. These packets must not be freed using any other
function than skb_complete_tx_timestamp. This commit fixes the one and only
driver using this API.

The driver first appeared in v3.0.

Signed-off-by: Richard Cochran <>
Cc: <>
 drivers/net/phy/dp83640.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index edd7304..311f5cb 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1060,7 +1060,7 @@  static void dp83640_txtstamp(struct phy_device *phydev,
 	struct dp83640_private *dp83640 = phydev->priv;
 	if (!dp83640->hwts_tx_en) {
-		kfree_skb(skb);
+		skb_complete_tx_timestamp(skb, NULL);
 	skb_queue_tail(&dp83640->tx_queue, skb);