[1/2] ARM: dts: tegra20: add labels to i2c nodes
diff mbox series

Message ID 20191219130431.30458-1-richard.leitner@skidata.com
State New
Headers show
Series
  • [1/2] ARM: dts: tegra20: add labels to i2c nodes
Related show

Commit Message

Richard Leitner Dec. 19, 2019, 1:04 p.m. UTC
Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
to alias it from derived boards.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 arch/arm/boot/dts/tegra20.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Dmitry Osipenko Dec. 20, 2019, 2 p.m. UTC | #1
19.12.2019 16:04, Richard Leitner пишет:
> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
> to alias it from derived boards.
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
>  arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 9c58e7fcf5c0..e02f75757a7e 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -464,7 +464,7 @@
>  		clocks = <&tegra_car TEGRA20_CLK_RTC>;
>  	};
>  
> -	i2c@7000c000 {
> +	i2c1: i2c@7000c000 {
>  		compatible = "nvidia,tegra20-i2c";
>  		reg = <0x7000c000 0x100>;
>  		interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> @@ -494,7 +494,7 @@
>  		status = "disabled";
>  	};
>  
> -	i2c@7000c400 {
> +	i2c2: i2c@7000c400 {
>  		compatible = "nvidia,tegra20-i2c";
>  		reg = <0x7000c400 0x100>;
>  		interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> @@ -510,7 +510,7 @@
>  		status = "disabled";
>  	};
>  
> -	i2c@7000c500 {
> +	i2c3: i2c@7000c500 {
>  		compatible = "nvidia,tegra20-i2c";
>  		reg = <0x7000c500 0x100>;
>  		interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
> 

Hello Richard,

Why derived boards couldn't label nodes by themselves? That's what all
derived boards are doing already.

BTW, upstream should benefit from the submitted changes. This is not a
very useful change for upstream if you're not updating the actual DTs of
any of the boards in arch/arm/boot/dts/*.
Richard Leitner Dec. 23, 2019, 7:46 a.m. UTC | #2
Hi,
thanks for the reply.

On 20/12/2019 15:00, Dmitry Osipenko wrote:
> 19.12.2019 16:04, Richard Leitner пишет:
>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>> to alias it from derived boards.
>>
>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>> ---
>>   arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)

...

> 
> Hello Richard,
> 
> Why derived boards couldn't label nodes by themselves? That's what all
> derived boards are doing already.

Of course they can, but IMHO its more useful to have the same labels for
all derived boards.

> 
> BTW, upstream should benefit from the submitted changes. This is not a
> very useful change for upstream if you're not updating the actual DTs of
> any of the boards in arch/arm/boot/dts/*.

That's true. I thought of also patching the actual DTs but wasn't sure
if that should be in the same series...
Based on your answer I guess it should be.

Therefore I'll send a v2 soon.

Thanks again & regards;richard.l
Dmitry Osipenko Dec. 23, 2019, 3:44 p.m. UTC | #3
23.12.2019 10:46, Richard Leitner пишет:
> Hi,
> thanks for the reply.
> 
> On 20/12/2019 15:00, Dmitry Osipenko wrote:
>> 19.12.2019 16:04, Richard Leitner пишет:
>>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>>> to alias it from derived boards.
>>>
>>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>>> ---
>>>   arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> ...
> 
>>
>> Hello Richard,
>>
>> Why derived boards couldn't label nodes by themselves? That's what all
>> derived boards are doing already.
> 
> Of course they can, but IMHO its more useful to have the same labels for
> all derived boards.
> 
>>
>> BTW, upstream should benefit from the submitted changes. This is not a
>> very useful change for upstream if you're not updating the actual DTs of
>> any of the boards in arch/arm/boot/dts/*.
> 
> That's true. I thought of also patching the actual DTs but wasn't sure
> if that should be in the same series...
> Based on your answer I guess it should be.
> 
> Therefore I'll send a v2 soon.
> 
> Thanks again & regards;richard.l

Seeing the full picture will be very helpful, thanks.

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index 9c58e7fcf5c0..e02f75757a7e 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -464,7 +464,7 @@ 
 		clocks = <&tegra_car TEGRA20_CLK_RTC>;
 	};
 
-	i2c@7000c000 {
+	i2c1: i2c@7000c000 {
 		compatible = "nvidia,tegra20-i2c";
 		reg = <0x7000c000 0x100>;
 		interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
@@ -494,7 +494,7 @@ 
 		status = "disabled";
 	};
 
-	i2c@7000c400 {
+	i2c2: i2c@7000c400 {
 		compatible = "nvidia,tegra20-i2c";
 		reg = <0x7000c400 0x100>;
 		interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
@@ -510,7 +510,7 @@ 
 		status = "disabled";
 	};
 
-	i2c@7000c500 {
+	i2c3: i2c@7000c500 {
 		compatible = "nvidia,tegra20-i2c";
 		reg = <0x7000c500 0x100>;
 		interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;