[ovs-dev,V5,15/18] netdev-offload-dpdk: Support offload of drop action
diff mbox series

Message ID 20191218144110.18653-16-elibr@mellanox.com
State Changes Requested
Delegated to: Ilya Maximets
Headers show
Series
  • netdev datapath actions offload
Related show

Commit Message

Eli Britstein Dec. 18, 2019, 2:41 p.m. UTC
Signed-off-by: Eli Britstein <elibr@mellanox.com>
Reviewed-by: Oz Shlomo <ozsh@mellanox.com>
---
 Documentation/howto/dpdk.rst | 1 +
 NEWS                         | 2 +-
 lib/netdev-offload-dpdk.c    | 5 +++--
 3 files changed, 5 insertions(+), 3 deletions(-)

Patch
diff mbox series

diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst
index f0fe2bef7..d9de7bedd 100644
--- a/Documentation/howto/dpdk.rst
+++ b/Documentation/howto/dpdk.rst
@@ -391,6 +391,7 @@  Supported protocols for hardware offload matches are:
 Supported actions for hardware offload are:
 
 - Output.
+- Drop.
 
 Further Reading
 ---------------
diff --git a/NEWS b/NEWS
index 8b8bcab9a..d66656df8 100644
--- a/NEWS
+++ b/NEWS
@@ -26,7 +26,7 @@  Post-v2.12.0
      * DPDK ring ports (dpdkr) are deprecated and will be removed in next
        releases.
      * Add support for DPDK 19.11.
-     * Add hardware offload support for output actions (experimental).
+     * Add hardware offload support for output and drop actions (experimental).
    - 'ovs-appctl dpctl/dump-flows' can now show offloaded=partial for
      partially offloaded flows, dp:dpdk for fully offloaded by dpdk, and
      type filter supports new filters: "dpdk" and "partially-offloaded".
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 6b3ca9f7d..295aa6b9d 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -367,6 +367,8 @@  dump_flow_action(struct ds *s, const struct rte_flow_action *actions)
         } else {
             ds_put_cstr(s, "  Port-id = null\n");
         }
+    } else if (actions->type == RTE_FLOW_ACTION_TYPE_DROP) {
+        ds_put_cstr(s, "rte flow drop action\n");
     } else {
         ds_put_format(s, "unknown rte flow action (%d)\n", actions->type);
     }
@@ -812,8 +814,7 @@  parse_flow_actions(struct netdev *netdev,
     }
 
     if (nl_actions_len == 0) {
-        VLOG_DBG_RL(&rl, "Unsupported action type drop");
-        return -1;
+        add_flow_action(actions, RTE_FLOW_ACTION_TYPE_DROP, NULL);
     }
 
     add_flow_action(actions, RTE_FLOW_ACTION_TYPE_END, NULL);