Patchwork [2/8] e2fsprogs: add exclude bitmap support in mkfs

login
register
mail settings
Submitter Yongqiang Yang
Date Oct. 23, 2011, 7:21 a.m.
Message ID <1319354488-6050-3-git-send-email-xiaoqiangnk@gmail.com>
Download mbox | patch
Permalink /patch/121217/
State Rejected
Headers show

Comments

Yongqiang Yang - Oct. 23, 2011, 7:21 a.m.
Exclude bitmap is needed by ext4 snapshot. This patch adds
exclude bitmap support in mkfs.

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
 misc/mke2fs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Amir G. - Oct. 23, 2011, 1:55 p.m.
This patch is missing some "meat".
Some parts of the previous patch should probably belong to this one,
like the patch to lib/ext2fs/alloc_tables.c.
Please keep this in mind for the next post.

Sorry for not noticing this when reviewing in github,
Amir.

On Sun, Oct 23, 2011 at 9:21 AM, Yongqiang Yang <xiaoqiangnk@gmail.com> wrote:
> Exclude bitmap is needed by ext4 snapshot. This patch adds
> exclude bitmap support in mkfs.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
> ---
>  misc/mke2fs.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 3dcb3b7..2dc28e7 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -828,6 +828,7 @@ static void parse_extended_opts(struct ext2_super_block *param,
>  static __u32 ok_features[3] = {
>        /* Compat */
>        EXT3_FEATURE_COMPAT_HAS_JOURNAL |
> +               EXT2_FEATURE_COMPAT_EXCLUDE_BITMAP |
>                EXT2_FEATURE_COMPAT_RESIZE_INODE |
>                EXT2_FEATURE_COMPAT_DIR_INDEX |
>                EXT2_FEATURE_COMPAT_EXT_ATTR,
> --
> 1.7.5.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 3dcb3b7..2dc28e7 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -828,6 +828,7 @@  static void parse_extended_opts(struct ext2_super_block *param,
 static __u32 ok_features[3] = {
 	/* Compat */
 	EXT3_FEATURE_COMPAT_HAS_JOURNAL |
+		EXT2_FEATURE_COMPAT_EXCLUDE_BITMAP |
 		EXT2_FEATURE_COMPAT_RESIZE_INODE |
 		EXT2_FEATURE_COMPAT_DIR_INDEX |
 		EXT2_FEATURE_COMPAT_EXT_ATTR,