Patchwork [06/11] powerpc/85xx: Add ethernet magic packet property to P1020 device tree

login
register
mail settings
Submitter Kumar Gala
Date Oct. 22, 2011, 9:20 p.m.
Message ID <1319318452-27036-6-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/121198/
State Accepted
Commit a45edbf9dc8cd7c7bfe2876b0efc2aee7bd6eb59
Headers show

Comments

Kumar Gala - Oct. 22, 2011, 9:20 p.m.
All eTSEC2 controllers support waking on magic packet so fixup device
tree to report that.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/boot/dts/p1020si.dtsi |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Scott Wood - Oct. 25, 2011, 10:19 p.m.
On 10/22/2011 04:20 PM, Kumar Gala wrote:
> All eTSEC2 controllers support waking on magic packet so fixup device
> tree to report that.

If they *all* support it, we can make the driver rely on the compatible
instead.

-Scott
Kumar Gala - Oct. 26, 2011, 3:35 a.m.
On Oct 25, 2011, at 5:19 PM, Scott Wood wrote:

> On 10/22/2011 04:20 PM, Kumar Gala wrote:
>> All eTSEC2 controllers support waking on magic packet so fixup device
>> tree to report that.
> 
> If they *all* support it, we can make the driver rely on the compatible
> instead.
> 
> -Scott

I think this might have originated on eTSEC v1, in which all controllers don't support it.

I'm not against removing it & just using compatible but don't know enough about these nodes to comment.

- k
Scott Wood - Oct. 26, 2011, 4:02 p.m.
On 10/25/2011 10:35 PM, Kumar Gala wrote:
> 
> On Oct 25, 2011, at 5:19 PM, Scott Wood wrote:
> 
>> On 10/22/2011 04:20 PM, Kumar Gala wrote:
>>> All eTSEC2 controllers support waking on magic packet so fixup device
>>> tree to report that.
>>
>> If they *all* support it, we can make the driver rely on the compatible
>> instead.
>>
>> -Scott
> 
> I think this might have originated on eTSEC v1, in which all controllers don't support it.

Sure, I was just talking about nodes with fsl,etsec2 -- especially if we
have device trees already out there that are missing the property.
Easier to change the driver.

-Scott

Patch

diff --git a/arch/powerpc/boot/dts/p1020si.dtsi b/arch/powerpc/boot/dts/p1020si.dtsi
index 5514e1d..14dff69 100644
--- a/arch/powerpc/boot/dts/p1020si.dtsi
+++ b/arch/powerpc/boot/dts/p1020si.dtsi
@@ -200,6 +200,7 @@ 
 			compatible = "fsl,etsec2";
 			fsl,num_rx_queues = <0x8>;
 			fsl,num_tx_queues = <0x8>;
+			fsl,magic-packet;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -226,6 +227,7 @@ 
 			compatible = "fsl,etsec2";
 			fsl,num_rx_queues = <0x8>;
 			fsl,num_tx_queues = <0x8>;
+			fsl,magic-packet;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -252,6 +254,7 @@ 
 			compatible = "fsl,etsec2";
 			fsl,num_rx_queues = <0x8>;
 			fsl,num_tx_queues = <0x8>;
+			fsl,magic-packet;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;