| Submitter | Clemens Buchacher |
|---|---|
| Date | Oct. 22, 2011, 12:56 p.m. |
| Message ID | <20111022125620.GA2256@ecki.lan> |
| Download | mbox | patch |
| Permalink | /patch/121183/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
On 22/10/11 15:56, Clemens Buchacher wrote: > If the device is down during suspend/resume, interrupts are enabled > without a registered interrupt handler, causing a storm of > unhandled interrupts until the IRQ is disabled because "nobody > cared". > > Instead, check that the device is up before touching it in the > suspend/resume code. > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=39112 Just tested the patch, suspend/resume works well.
From: "Mantas M." <grawity@gmail.com> Date: Sat, 22 Oct 2011 19:27:09 +0300 > On 22/10/11 15:56, Clemens Buchacher wrote: >> If the device is down during suspend/resume, interrupts are enabled >> without a registered interrupt handler, causing a storm of >> unhandled interrupts until the IRQ is disabled because "nobody >> cared". >> >> Instead, check that the device is up before touching it in the >> suspend/resume code. >> >> Fixes https://bugzilla.kernel.org/show_bug.cgi?id=39112 > > Just tested the patch, suspend/resume works well. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/net/jme.c b/drivers/net/jme.c index 3ac262f..7a8a3b6 100644 --- a/drivers/net/jme.c +++ b/drivers/net/jme.c @@ -3131,6 +3131,9 @@ jme_suspend(struct device *dev) struct net_device *netdev = pci_get_drvdata(pdev); struct jme_adapter *jme = netdev_priv(netdev); + if (!netif_running(netdev)) + return 0; + atomic_dec(&jme->link_changing); netif_device_detach(netdev); @@ -3171,6 +3174,9 @@ jme_resume(struct device *dev) struct net_device *netdev = pci_get_drvdata(pdev); struct jme_adapter *jme = netdev_priv(netdev); + if (!netif_running(netdev)) + return 0; + jme_clear_pm(jme); jme_phy_on(jme); if (test_bit(JME_FLAG_SSET, &jme->flags))
If the device is down during suspend/resume, interrupts are enabled without a registered interrupt handler, causing a storm of unhandled interrupts until the IRQ is disabled because "nobody cared". Instead, check that the device is up before touching it in the suspend/resume code. Fixes https://bugzilla.kernel.org/show_bug.cgi?id=39112 Helped-by: Adrian Chadd <adrian@freebsd.org> Helped-by: Mohammed Shafi <shafi.wireless@gmail.com> Signed-off-by: Clemens Buchacher <drizzd@aon.at> --- Unfortunately, bugzilla.kernel.org is still down. There is at least one other person who reported the issue, and I don't have their email address. So for now, I am the only one who tested this fix. The patch applies to current tip (2efd7c0) of Linus' tree. I also tested it based on v3.0 and it worked the same. Many thanks to Adrian and Mohammed for helping me debug this issue. See this thread for the history: http://mid.gmane.org/20110827113253.GA1444@ecki drivers/net/jme.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)