| Message ID | 20191217210230.24745-1-oscar.ravadilla@alliedtelesis.co.nz |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | [v2] mtd: rawnand: brcmnand: Add bad block marker option. | expand |
On 12/17/19 1:02 PM, Oscar Ravadilla wrote: > Fixes: 04649ec1335f ("mtd: rawnand: Always store info about bad > block markers in chip struct") > > The commit above changed where the information of the bad block > markers are stored. It is now stored in nand_chip.options and > nand_chip.badblockpos. However brcmnand driver wasn't updated > so it now fails to handle bad blocks. > > So update brcmnand driver to add bad block markers to nand_chip.options. > > Signed-off-by: Oscar Ravadilla <oscar.ravadilla@alliedtelesis.co.nz> > --- > Notes: > Changelog > v1->v2: > - Update commit message to add the "Fixes: ... " tag. Thank you for the quick respin, the Fixes: tag should be placed right above your Signed-off-by since it is not such a special tag after all, depending on the feedback, there may, or may not be a need to resubmit this patch. > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index 1a66b1cd51c0..68d37d1636ae 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -2360,6 +2360,8 @@ static int brcmnand_attach_chip(struct nand_chip *chip) > * needed. > */ > chip->options |= NAND_USE_BOUNCE_BUFFER; > + chip->options |= | NAND_BBM_SECONDPAGE | > + NAND_BBM_LASTPAGE; > > if (chip->bbt_options & NAND_BBT_USE_FLASH) > chip->bbt_options |= NAND_BBT_NO_OOB; >
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index 1a66b1cd51c0..68d37d1636ae 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -2360,6 +2360,8 @@ static int brcmnand_attach_chip(struct nand_chip *chip) * needed. */ chip->options |= NAND_USE_BOUNCE_BUFFER; + chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE | + NAND_BBM_LASTPAGE; if (chip->bbt_options & NAND_BBT_USE_FLASH) chip->bbt_options |= NAND_BBT_NO_OOB;
Fixes: 04649ec1335f ("mtd: rawnand: Always store info about bad block markers in chip struct") The commit above changed where the information of the bad block markers are stored. It is now stored in nand_chip.options and nand_chip.badblockpos. However brcmnand driver wasn't updated so it now fails to handle bad blocks. So update brcmnand driver to add bad block markers to nand_chip.options. Signed-off-by: Oscar Ravadilla <oscar.ravadilla@alliedtelesis.co.nz> --- Notes: Changelog v1->v2: - Update commit message to add the "Fixes: ... " tag. --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 ++ 1 file changed, 2 insertions(+)