From patchwork Sat Oct 22 05:54:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/4] Add missing page rounding of a page_entry Date: Fri, 21 Oct 2011 19:54:10 -0000 From: Andi Kleen X-Patchwork-Id: 121155 Message-Id: <1319262853-32370-2-git-send-email-andi@firstfloor.org> To: gcc-patches@gcc.gnu.org Cc: Andi Kleen From: Andi Kleen This one place in ggc forgot to round page_entry->bytes to the next page boundary, which lead to all the heuristics in freeing to check for continuous memory failing. Round here too, like all other allocators already do. The memory consumed should be the same for MMAP because the kernel would round anyways. It may slightly increase memory usage when malloc groups are used. This will also increase the hitrate on the free page list slightly. gcc/: 2011-10-18 Andi Kleen * ggc-page.c (alloc_pages): Always round up entry_size. --- gcc/ggc-page.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gcc/ggc-page.c b/gcc/ggc-page.c index 2da99db..ba88e3f 100644 --- a/gcc/ggc-page.c +++ b/gcc/ggc-page.c @@ -736,6 +736,7 @@ alloc_page (unsigned order) entry_size = num_objects * OBJECT_SIZE (order); if (entry_size < G.pagesize) entry_size = G.pagesize; + entry_size = ROUND_UP (entry_size, G.pagesize); entry = NULL; page = NULL;